-
-
Notifications
You must be signed in to change notification settings - Fork 585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for stable MSC3882 get_login_token #3416
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
hughns
force-pushed
the
hughns/stable-msc3882
branch
from
September 21, 2023 15:15
0d1a113
to
ce362c5
Compare
hughns
force-pushed
the
hughns/stable-msc3882
branch
from
September 22, 2023 17:04
ce362c5
to
07b3d93
Compare
hughns
force-pushed
the
hughns/stable-msc3882
branch
from
September 27, 2023 08:50
d4bea4f
to
c7c0b5f
Compare
This was referenced Sep 27, 2023
Merged
richvdh
requested changes
Sep 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally seems good; a few nits
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
richvdh
reviewed
Sep 28, 2023
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
hughns
force-pushed
the
hughns/stable-msc3882
branch
from
September 28, 2023 15:22
1491803
to
61086c5
Compare
richvdh
approved these changes
Sep 28, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sep 28, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sep 29, 2023
I would force merge but there is another PR in the queue, so let's try updating the branch to my latest changes in the hope that they unflake it. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Here's what your changelog entry will look like:
✨ Features