-
-
Notifications
You must be signed in to change notification settings - Fork 599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support optional MSC3860 redirects #4007
Conversation
See `allow_redirect` across the media endpoints: https://spec.matrix.org/v1.9/client-server-api/#client-behaviour-7
* Support optional MSC3860 redirects See `allow_redirect` across the media endpoints: https://spec.matrix.org/v1.9/client-server-api/#client-behaviour-7 * Update the tests * Appease the linter * Add test to appease SonarCloud
@turt2live I don't know if you noticed, but this PR got removed from the review queue due to failing downstream tests. Looks like you need to make a PR for react-sdk to handle the new URLs that this PR creates. |
There is a react-sdk PR: matrix-org/matrix-react-sdk#12142 |
* Enable redirected media by default See matrix-org/matrix-js-sdk#4007 * Update the tests * Update tests * Update end-to-end tests too
…efaulting to `false` Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
After discussing with Travis, to avoid a backwards incompatible change (for tests at least) we've gone with only sending the param if a boolean is passed for the new param |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't approve my own PR, but explicit behaviour lgtm, thanks :)
* Enable redirected media by default See matrix-org/matrix-js-sdk#4007 * Update the tests * Update tests * Update end-to-end tests too * Update linkifier to use Media customisation endpoint * Fix tests for new js-sdk behaviour * Fix unchanged file * Fix linkifier * Fix lint
See
allow_redirect
across the media endpoints: https://spec.matrix.org/v1.9/client-server-api/#client-behaviour-7Checklist
Here's what your changelog entry will look like:
✨ Features