Fix state_events.ts types #4196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
|
If this is a "fix", please could you link to the PR that broke it and describe what was broken, for future archaeologists? |
|
The change looks right, but I'm somewhat surprised we didn't discover the problem sooner. Don't we hit this codepath in Element Web? |
Looks like it is due to explicit typecasts on the React SDK callers
|
(we should probably remove those typecasts) |
richvdh
approved these changes
May 10, 2024
Yup, have a changeset brewing locally with that and switching from the deprecated type |
|
It's now in matrix-org/matrix-react-sdk#12513 |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regressed by #4105