Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factor out MatrixFederationAgent #3

Open
DMRobertson opened this issue Nov 24, 2021 · 0 comments
Open

Factor out MatrixFederationAgent #3

DMRobertson opened this issue Nov 24, 2021 · 0 comments

Comments

@DMRobertson
Copy link
Contributor

Sydent: sydent/sydent/http/matrixfederationagent.py
synapse: synapse/synapse/http/federation/matrix_federation_agent.py

And possibly these two in Synapse too?

synapse/tests/http/test_proxyagent.py
211:class MatrixFederationAgentTests(TestCase):

synapse/tests/http/federation/test_matrix_federation_agent.py
64:class MatrixFederationAgentTests(unittest.TestCase):
DMRobertson pushed a commit to matrix-org/sydent that referenced this issue Nov 24, 2021
This accounts for [this Sentry error](https://sentry.matrix.org/sentry/sydent/issues/236101/).

I haven't written a test for this because a) I'm hungry and b) this
is shared code with Synapse which ought to be pulled out to a common
library and tested there; c.f.
matrix-org/matrix-python-common#3.
DMRobertson pushed a commit to matrix-org/sydent that referenced this issue Nov 25, 2021
This accounts for [this Sentry error](https://sentry.matrix.org/sentry/sydent/issues/236101/).

I haven't written a test for this because a) I'm hungry and b) this
is shared code with Synapse which ought to be pulled out to a common
library and tested there; c.f.
matrix-org/matrix-python-common#3.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant