Retry if request failed due to rate-limit #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan Petykiewicz <anewusername@gmail.com>
|
Can one of the admins verify this patch? |
|
ok to test |
|
LGTM |
pik
reviewed
Apr 17, 2017
| verify=self.validate_cert | ||
| ) | ||
| response = None | ||
| while True: |
There was a problem hiding this comment.
Adding blocking code to the default _send method in the SDK is really not a nice idea. Clients using the SDK can have different concurrency models and dealing with re-tries is much better left to them.
There was a problem hiding this comment.
Hmm, you might be right on this one. It probably would make more sense to make this optional.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporary fix for #6 so things stop failing due to rate-limits.
If the request fails, waits retry_after_ms and then resends it.
Signed-off-by: Jan Petykiewicz anewusername@gmail.com