Run a minor code quality checker over the repo (#8524)

* Run a minor code quality checker over the repo

Largely targeted at spelling of common words and misc code issues.

* Update snapshots

src/BasePlatform.ts

@@ -237,7 +237,7 @@ export default abstract class BasePlatform {
     }
 
     /**
-     * Restarts the application, without neccessarily reloading
+     * Restarts the application, without necessarily reloading
      * any application code
      */
     abstract reload();

src/CallHandler.tsx

@@ -948,7 +948,7 @@ export default class CallHandler extends EventEmitter {
     ): Promise<void> {
         if (consultFirst) {
             // if we're consulting, we just start by placing a call to the transfer
-            // target (passing the transferee so the actual tranfer can happen later)
+            // target (passing the transferee so the actual transfer can happen later)
             this.dialNumber(destination, call);
             return;
         }

src/HtmlUtils.tsx

@@ -187,7 +187,7 @@ const transformTags: IExtendedSanitizeOptions["transformTags"] = { // custom to
                 delete attribs.target;
             }
         } else {
-            // Delete the href attrib if it is falsey
+            // Delete the href attrib if it is falsy
             delete attribs.href;
         }
 

src/ImageUtils.ts

@@ -25,7 +25,7 @@ limitations under the License.
  * reflect the actual height the scaled thumbnail occupies.
  *
  * This is very useful for calculating how much height a thumbnail will actually
- * consume in the timeline, when performing scroll offset calcuations
+ * consume in the timeline, when performing scroll offset calculations
  * (e.g. scroll locking)
  */
 export function thumbHeight(fullWidth: number, fullHeight: number, thumbWidth: number, thumbHeight: number) {

src/Rooms.ts

@@ -52,7 +52,7 @@ export function looksLikeDirectMessageRoom(room: Room, myUserId: string): boolea
         // Used to split rooms via tags
         const tagNames = Object.keys(room.tags);
         // Used for 1:1 direct chats
-        // Show 1:1 chats in seperate "Direct Messages" section as long as they haven't
+        // Show 1:1 chats in separate "Direct Messages" section as long as they haven't
         // been moved to a different tag section
         const totalMemberCount = room.currentState.getJoinedMemberCount() +
             room.currentState.getInvitedMemberCount();

src/async-components/views/dialogs/security/CreateKeyBackupDialog.tsx

@@ -291,7 +291,7 @@ export default class CreateKeyBackupDialog extends React.PureComponent<IProps, I
             changeText = _t("Use a different passphrase?");
         } else if (!this.state.passPhrase.startsWith(this.state.passPhraseConfirm)) {
             // only tell them they're wrong if they've actually gone wrong.
-            // Security concious readers will note that if you left element-web unattended
+            // Security conscious readers will note that if you left element-web unattended
             // on this screen, this would make it easy for a malicious person to guess
             // your passphrase one letter at a time, but they could get this faster by
             // just opening the browser's developer tools and reading it.

src/async-components/views/dialogs/security/CreateSecretStorageDialog.tsx

@@ -649,7 +649,7 @@ export default class CreateSecretStorageDialog extends React.PureComponent<IProp
             changeText = _t("Use a different passphrase?");
         } else if (!this.state.passPhrase.startsWith(this.state.passPhraseConfirm)) {
             // only tell them they're wrong if they've actually gone wrong.
-            // Security concious readers will note that if you left element-web unattended
+            // Security conscious readers will note that if you left element-web unattended
             // on this screen, this would make it easy for a malicious person to guess
             // your passphrase one letter at a time, but they could get this faster by
             // just opening the browser's developer tools and reading it.

src/components/views/auth/CountryDropdown.tsx

@@ -135,7 +135,7 @@ export default class CountryDropdown extends React.Component<IProps, IState> {
         });
 
         // default value here too, otherwise we need to handle null / undefined
-        // values between mounting and the initial value propgating
+        // values between mounting and the initial value propagating
         const value = this.props.value || this.state.defaultCountry.iso2;
 
         return <Dropdown

src/components/views/beacon/LeftPanelLiveShareWarning.tsx

@@ -56,7 +56,7 @@ const getLabel = (hasStoppingErrors: boolean, hasLocationErrors: boolean): strin
         return _t('An error occurred while stopping your live location');
     }
     if (hasLocationErrors) {
-        return _t('An error occured whilst sharing your live location');
+        return _t('An error occurred whilst sharing your live location');
     }
     return _t('You are sharing your live location');
 };

src/components/views/beacon/RoomLiveShareWarning.tsx

@@ -29,7 +29,7 @@ import LiveTimeRemaining from './LiveTimeRemaining';
 
 const getLabel = (hasLocationPublishError: boolean, hasStopSharingError: boolean): string => {
     if (hasLocationPublishError) {
-        return _t('An error occured whilst sharing your live location, please try again');
+        return _t('An error occurred whilst sharing your live location, please try again');
     }
     if (hasStopSharingError) {
         return _t('An error occurred while stopping your live location, please try again');

src/components/views/dialogs/BulkRedactDialog.tsx

@@ -25,7 +25,7 @@ import { EventType } from "matrix-js-sdk/src/@types/event";
 import { _t } from '../../../languageHandler';
 import dis from "../../../dispatcher/dispatcher";
 import { Action } from "../../../dispatcher/actions";
-import { IDialogProps } from "../dialogs/IDialogProps";
+import { IDialogProps } from "./IDialogProps";
 import BaseDialog from "../dialogs/BaseDialog";
 import InfoDialog from "../dialogs/InfoDialog";
 import DialogButtons from "../elements/DialogButtons";

src/components/views/dialogs/ExportDialog.tsx

@@ -263,7 +263,7 @@ const ExportDialog: React.FC<IProps> = ({ room, onFinished }) => {
         else onFinished(false);
     };
 
-    const confirmCanel = async () => {
+    const confirmCancel = async () => {
         await exporter?.cancelExport();
         setExportCancelled(true);
         setExporting(false);
@@ -346,7 +346,7 @@ const ExportDialog: React.FC<IProps> = ({ room, onFinished }) => {
                     hasCancel={true}
                     cancelButton={_t("Continue")}
                     onCancel={() => setCancelWarning(false)}
-                    onPrimaryButtonClick={confirmCanel}
+                    onPrimaryButtonClick={confirmCancel}
                 />
             </BaseDialog>
         );

src/components/views/dialogs/KeySignatureUploadFailedDialog.tsx

@@ -29,7 +29,7 @@ interface IProps extends IDialogProps {
         error: string;
     }>>;
     source: string;
-    continuation: () => void;
+    continuation: () => Promise<void>;
 }
 
 const KeySignatureUploadFailedDialog: React.FC<IProps> = ({

src/components/views/dialogs/ShareDialog.tsx

@@ -52,7 +52,7 @@ const socials = [
     }, {
         name: 'Reddit',
         img: require("../../../../res/img/social/reddit.png"),
-        url: (url) => `http://www.reddit.com/submit?url=${url}`,
+        url: (url) => `https://www.reddit.com/submit?url=${url}`,
     }, {
         name: 'email',
         img: require("../../../../res/img/social/email-1.png"),

src/components/views/dialogs/security/RestoreKeyBackupDialog.tsx

@@ -44,7 +44,7 @@ enum ProgressState {
 }
 
 interface IProps extends IDialogProps {
-    // if false, will close the dialog as soon as the restore completes succesfully
+    // if false, will close the dialog as soon as the restore completes successfully
     // default: true
     showSummary?: boolean;
     // If specified, gather the key from the user but then call the function with the backup

src/components/views/elements/AccessibleButton.tsx

@@ -96,7 +96,7 @@ export default function AccessibleButton({
         // that might receive focus as a result of the AccessibleButtonClick action
         // It's because we are using html buttons at a few places e.g. inside dialogs
         // And divs which we report as role button to assistive technologies.
-        // Browsers handle space and enter keypresses differently and we are only adjusting to the
+        // Browsers handle space and enter key presses differently and we are only adjusting to the
         // inconsistencies here
         newProps.onKeyDown = (e) => {
             const action = getKeyBindingsManager().getAccessibilityAction(e);

src/components/views/elements/AppTile.tsx

@@ -57,7 +57,7 @@ interface IProps {
     // which bypasses permission prompts as it was added explicitly by that user
     room?: Room;
     threadId?: string | null;
-    // Specifying 'fullWidth' as true will render the app tile to fill the width of the app drawer continer.
+    // Specifying 'fullWidth' as true will render the app tile to fill the width of the app drawer container.
     // This should be set to true when there is only one widget in the app drawer, otherwise it should be false.
     fullWidth?: boolean;
     // Optional. If set, renders a smaller view of the widget
@@ -288,7 +288,7 @@ export default class AppTile extends React.Component<IProps, IState> {
     private setupSgListeners() {
         this.sgWidget.on("preparing", this.onWidgetPreparing);
         this.sgWidget.on("ready", this.onWidgetReady);
-        // emits when the capabilites have been setup or changed
+        // emits when the capabilities have been set up or changed
         this.sgWidget.on("capabilitiesNotified", this.onWidgetCapabilitiesNotified);
     }
 
@@ -543,7 +543,7 @@ export default class AppTile extends React.Component<IProps, IState> {
         const sandboxFlags = "allow-forms allow-popups allow-popups-to-escape-sandbox " +
             "allow-same-origin allow-scripts allow-presentation allow-downloads";
 
-        // Additional iframe feature pemissions
+        // Additional iframe feature permissions
         // (see - https://sites.google.com/a/chromium.org/dev/Home/chromium-security/deprecating-permissions-in-cross-origin-iframes and https://wicg.github.io/feature-policy/)
         const iframeFeatures = "microphone; camera; encrypted-media; autoplay; display-capture; clipboard-write;";
 

src/components/views/elements/ErrorBoundary.tsx

@@ -53,7 +53,7 @@ export default class ErrorBoundary extends React.PureComponent<{}, IState> {
         // in their own `console.error` invocation.
         logger.error(error);
         logger.error(
-            "The above error occured while React was rendering the following components:",
+            "The above error occurred while React was rendering the following components:",
             componentStack,
         );
     }

src/components/views/elements/LanguageDropdown.tsx

@@ -99,7 +99,7 @@ export default class LanguageDropdown extends React.Component<IProps, IState> {
         });
 
         // default value here too, otherwise we need to handle null / undefined
-        // values between mounting and the initial value propgating
+        // values between mounting and the initial value propagating
         let language = SettingsStore.getValue("language", null, /*excludeDefault:*/true);
         let value = null;
         if (language) {

src/components/views/elements/ReplyChain.tsx

@@ -167,7 +167,7 @@ export default class ReplyChain extends React.Component<IProps, IState> {
             await this.matrixClient.getEventTimeline(this.room.getUnfilteredTimelineSet(), eventId);
         } catch (e) {
             // if it fails catch the error and return early, there's no point trying to find the event in this case.
-            // Return null as it is falsey and thus should be treated as an error (as the event cannot be resolved).
+            // Return null as it is falsy and thus should be treated as an error (as the event cannot be resolved).
             return null;
         }
         return this.room.findEventById(eventId);

src/components/views/elements/SpellCheckLanguagesDropdown.tsx

@@ -99,7 +99,7 @@ export default class SpellCheckLanguagesDropdown extends React.Component<SpellCh
         });
 
         // default value here too, otherwise we need to handle null / undefined;
-        // values between mounting and the initial value propgating
+        // values between mounting and the initial value propagating
         let language = SettingsStore.getValue("language", null, /*excludeDefault:*/true);
         let value = null;
         if (language) {

src/components/views/elements/TruncatedList.tsx

@@ -52,7 +52,7 @@ export default class TruncatedList extends React.Component<IProps> {
             return this.props.getChildren(start, end);
         } else {
             // XXX: I'm not sure why anything would pass null into this, it seems
-            // like a bizzare case to handle, but I'm preserving the behaviour.
+            // like a bizarre case to handle, but I'm preserving the behaviour.
             // (see commit 38d5c7d5c5d5a34dc16ef5d46278315f5c57f542)
             return React.Children.toArray(this.props.children).filter((c) => {
                 return c != null;

src/components/views/messages/MImageBody.tsx

@@ -485,14 +485,14 @@ export default class MImageBody extends React.Component<IBodyProps, IState> {
         return this.wrapImage(contentUrl, thumbnail);
     }
 
-    // Overidden by MStickerBody
+    // Overridden by MStickerBody
     protected wrapImage(contentUrl: string, children: JSX.Element): JSX.Element {
         return <a href={contentUrl} target={this.props.forExport ? "_blank" : undefined} onClick={this.onClick}>
             { children }
         </a>;
     }
 
-    // Overidden by MStickerBody
+    // Overridden by MStickerBody
     protected getPlaceholder(width: number, height: number): JSX.Element {
         const blurhash = this.props.mxEvent.getContent().info?.[BLURHASH_FIELD];
 
@@ -506,12 +506,12 @@ export default class MImageBody extends React.Component<IBodyProps, IState> {
         return <Spinner w={32} h={32} />;
     }
 
-    // Overidden by MStickerBody
+    // Overridden by MStickerBody
     protected getTooltip(): JSX.Element {
         return null;
     }
 
-    // Overidden by MStickerBody
+    // Overridden by MStickerBody
     protected getFileBody(): string | JSX.Element {
         if (this.props.forExport) return null;
         /*

src/components/views/rooms/AppsDrawer.tsx

@@ -49,7 +49,7 @@ interface IState {
     // @ts-ignore - TS wants a string key, but we know better
     apps: {[id: Container]: IApp[]};
     resizingVertical: boolean; // true when changing the height of the apps drawer
-    resizingHorizontal: boolean; // true when chagning the distribution of the width between widgets
+    resizingHorizontal: boolean; // true when changing the distribution of the width between widgets
     resizing: boolean;
 }
 
@@ -259,7 +259,7 @@ export default class AppsDrawer extends React.Component<IProps, IState> {
             mx_AppsDrawer_2apps: apps.length === 2,
             mx_AppsDrawer_3apps: apps.length === 3,
         });
-        const appConatiners =
+        const appContainers =
             <div className="mx_AppsContainer" ref={this.collectResizer}>
                 { apps.map((app, i) => {
                     if (i < 1) return app;
@@ -272,7 +272,7 @@ export default class AppsDrawer extends React.Component<IProps, IState> {
 
         let drawer;
         if (widgetIsMaxmised) {
-            drawer = appConatiners;
+            drawer = appContainers;
         } else {
             drawer = <PersistentVResizer
                 room={this.props.room}
@@ -282,7 +282,7 @@ export default class AppsDrawer extends React.Component<IProps, IState> {
                 handleWrapperClass="mx_AppsContainer_resizerHandleContainer"
                 className="mx_AppsContainer_resizer"
                 resizeNotifier={this.props.resizeNotifier}>
-                { appConatiners }
+                { appContainers }
             </PersistentVResizer>;
         }
 

src/components/views/rooms/AuxPanel.tsx

@@ -104,7 +104,7 @@ export default class AuxPanel extends React.Component<IProps, IState> {
                 const severity = ev.getContent().severity || "normal";
                 const stateKey = ev.getStateKey();
 
-                // We want a non-empty title but can accept falsey values (e.g.
+                // We want a non-empty title but can accept falsy values (e.g.
                 // zero)
                 if (title && value !== undefined) {
                     counters.push({

src/components/views/rooms/EventTile.tsx

@@ -212,7 +212,7 @@ interface IProps {
     // whether or not to display thread info
     showThreadInfo?: boolean;
 
-    // if specified and `true`, the message his behing
+    // if specified and `true`, the message is being
     // hidden for moderation from other users but is
     // displayed to the current user either because they're
     // the author or they are a moderator

src/components/views/toasts/VerificationRequestToast.tsx

@@ -66,7 +66,7 @@ export default class VerificationRequestToast extends React.PureComponent<IProps
         request.on(VerificationRequestEvent.Change, this.checkRequestIsPending);
         // We should probably have a separate class managing the active verification toasts,
         // rather than monitoring this in the toast component itself, since we'll get problems
-        // like the toasdt not going away when the verification is cancelled unless it's the
+        // like the toast not going away when the verification is cancelled unless it's the
         // one on the top (ie. the one that's mounted).
         // As a quick & dirty fix, check the toast is still relevant when it mounts (this prevents
         // a toast hanging around after logging in if you did a verification as part of login).

src/dispatcher/payloads/ComposerInsertPayload.ts

@@ -28,7 +28,7 @@ export enum ComposerType {
 interface IBaseComposerInsertPayload extends ActionPayload {
     action: Action.ComposerInsert;
     timelineRenderingType: TimelineRenderingType;
-    composerType?: ComposerType; // falsey if should be re-dispatched to the correct composer
+    composerType?: ComposerType; // falsy if should be re-dispatched to the correct composer
 }
 
 interface IComposerInsertMentionPayload extends IBaseComposerInsertPayload {

src/editor/dom.ts

@@ -178,7 +178,7 @@ function getTextNodeValue(node: Node): string {
         if (nodeText.length !== 1) {
             return nodeText.replace(CARET_NODE_CHAR, "");
         } else {
-            // only contains ZWS, which is ignored, so return emtpy string
+            // only contains ZWS, which is ignored, so return empty string
             return "";
         }
     } else {

src/editor/operations.ts

@@ -37,7 +37,7 @@ export function formatRange(range: Range, action: Formatting): void {
         range.trim();
     }
 
-    // Edgecase when just selecting whitespace or new line.
+    // Edge case when just selecting whitespace or new line.
     // There should be no reason to format whitespace, so we can just return.
     if (range.length === 0) {
         return;

src/i18n/strings/en_EN.json

@@ -2957,11 +2957,11 @@
     "View List": "View List",
     "Close sidebar": "Close sidebar",
     "An error occurred while stopping your live location": "An error occurred while stopping your live location",
-    "An error occured whilst sharing your live location": "An error occured whilst sharing your live location",
+    "An error occurred whilst sharing your live location": "An error occurred whilst sharing your live location",
     "You are sharing your live location": "You are sharing your live location",
     "%(timeRemaining)s left": "%(timeRemaining)s left",
     "Live location enabled": "Live location enabled",
-    "An error occured whilst sharing your live location, please try again": "An error occured whilst sharing your live location, please try again",
+    "An error occurred whilst sharing your live location, please try again": "An error occurred whilst sharing your live location, please try again",
     "An error occurred while stopping your live location, please try again": "An error occurred while stopping your live location, please try again",
     "Stop sharing": "Stop sharing",
     "Stop sharing and close": "Stop sharing and close",

src/indexing/BaseEventIndexManager.ts

@@ -91,7 +91,7 @@ export default abstract class BaseEventIndexManager {
      *
      * @param {MatrixEvent} ev The event that should be added to the index.
      * @param {IMatrixProfile} profile The profile of the event sender at the
-     * time of the event receival.
+     * time the event was received.
      *
      * @return {Promise} A promise that will resolve when the was queued up for
      * addition.