Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Commit

Permalink
Fix reading of cached room device setting values (#8491)
Browse files Browse the repository at this point in the history
* Fix reading of cached room device setting values

* Add tests

(cherry picked from commit 5cdc8fb)
  • Loading branch information
t3chguy committed May 4, 2022
1 parent 9e55dda commit 81d135f
Show file tree
Hide file tree
Showing 2 changed files with 36 additions and 1 deletion.
2 changes: 1 addition & 1 deletion src/settings/handlers/RoomDeviceSettingsHandler.ts
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ export default class RoomDeviceSettingsHandler extends AbstractLocalStorageSetti
}

private read(key: string): any {
return this.getItem(key);
return this.getObject(key);
}

private getKey(settingName: string, roomId: string): string {
Expand Down
35 changes: 35 additions & 0 deletions test/settings/handlers/RoomDeviceSettingsHandler-test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
/*
Copyright 2022 The Matrix.org Foundation C.I.C.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/

import RoomDeviceSettingsHandler from "../../../src/settings/handlers/RoomDeviceSettingsHandler";
import { WatchManager } from "../../../src/settings/WatchManager";

describe("RoomDeviceSettingsHandler", () => {
it("should correctly read cached values", () => {
const watchers = new WatchManager();
const handler = new RoomDeviceSettingsHandler(watchers);

const settingName = "RightPanel.phases";
const roomId = "!room:server";
const value = {
isOpen: true,
history: [{}],
};

handler.setValue(settingName, roomId, value);
expect(handler.getValue(settingName, roomId)).toEqual(value);
});
});

0 comments on commit 81d135f

Please sign in to comment.