Improve context types (#10510)

matrix-org · Apr 4, 2023 · b77b2df · b77b2df
1 parent 974dc35
commit b77b2df
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/src/contexts/MatrixClientContext.tsx b/src/contexts/MatrixClientContext.tsx
@@ -25,7 +25,10 @@ import React, {
 } from "react";
 import { MatrixClient } from "matrix-js-sdk/src/client";
 
-const MatrixClientContext = createContext<MatrixClient | undefined>(undefined);
+// This context is available to components under LoggedInView,
+// the context must not be used by components outside a MatrixClientContext tree.
+// This assertion allows us to make the type not nullable.
+const MatrixClientContext = createContext<MatrixClient>(null as any);
 MatrixClientContext.displayName = "MatrixClientContext";
 export default MatrixClientContext;
 

diff --git a/src/contexts/SDKContext.ts b/src/contexts/SDKContext.ts
@@ -38,7 +38,10 @@ import {
     VoiceBroadcastRecordingsStore,
 } from "../voice-broadcast";
 
-export const SDKContext = createContext<SdkContextClass | undefined>(undefined);
+// This context is available to components under MatrixChat,
+// the context must not be used by components outside a SdkContextClass tree.
+// This assertion allows us to make the type not nullable.
+export const SDKContext = createContext<SdkContextClass>(null as any);
 SDKContext.displayName = "SDKContext";
 
 /**