Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Migrate RoomView to support MSC3946 #10088

Merged
merged 3 commits into from
Feb 10, 2023

Conversation

weeman1337
Copy link
Contributor

@weeman1337 weeman1337 commented Feb 6, 2023

Jest tests are not great. They should be improved when migrating RoomView-test to react testing library.

Tested in the application

prede

closes element-hq/element-web#24324

PSF-1896

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@weeman1337 weeman1337 added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Feb 6, 2023
@weeman1337 weeman1337 marked this pull request as ready for review February 6, 2023 13:30
@weeman1337 weeman1337 requested a review from a team as a code owner February 6, 2023 13:30
Copy link
Contributor

@andybalaam andybalaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@weeman1337 weeman1337 merged commit 671fdc8 into develop Feb 10, 2023
@weeman1337 weeman1337 deleted the weeman1337/predecessor-room-view branch February 10, 2023 07:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gitter sunsetting: ensure hidden highlights code respects MSC3946
3 participants