Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Add E2E test of audio player #10441

Merged
merged 75 commits into from
Apr 6, 2023
Merged

Add E2E test of audio player #10441

Show file tree
Hide file tree
Changes from 71 commits
Commits
Show all changes
75 commits
Select commit Hold shift + click to select a range
4dcc8e7
Add audio-player.spec.ts
luixxiul Mar 19, 2023
1694921
Download audio file
luixxiul Mar 19, 2023
ddc7898
Reply
luixxiul Mar 19, 2023
b8facfe
ReplyChain
luixxiul Mar 19, 2023
f88ff9c
Audio player on a thread
luixxiul Mar 19, 2023
133cf69
Add 'wrapper' option to takeSnapshots() in mx_ThreadView
luixxiul Mar 23, 2023
2e55e28
Click timestamps to highlight mx_EventTile to hopefully avoid flaky P…
luixxiul Mar 23, 2023
f2a6d0a
Assert that the radio button for light theme was checked
luixxiul Mar 24, 2023
c6cf476
Typo
luixxiul Mar 24, 2023
f23cfc2
Update cypress/e2e/audio-player/audio-player.spec.ts
luixxiul Mar 24, 2023
617f979
Update cypress/e2e/audio-player/audio-player.spec.ts
luixxiul Mar 24, 2023
b282fff
Update cypress/e2e/audio-player/audio-player.spec.ts
luixxiul Mar 24, 2023
c6b908d
Update cypress/e2e/audio-player/audio-player.spec.ts
luixxiul Mar 24, 2023
f0b120e
Update cypress/e2e/audio-player/audio-player.spec.ts
luixxiul Mar 24, 2023
495b612
Add comments to const percyCSS
luixxiul Mar 25, 2023
649d20b
Remove double quotation marks inside backticks
luixxiul Mar 25, 2023
445be1d
Rename a test
luixxiul Mar 25, 2023
3742b4f
Rename a test and edit a comment on mx_ReplyChain
luixxiul Mar 25, 2023
f6ffc1a
Wait until rendering of the player settled and assert that the play b…
luixxiul Mar 25, 2023
b18794d
Extract the test for IRC layout
luixxiul Mar 25, 2023
36b650e
Add and edit comments for takeSnapshots() and the test on IRC layout
luixxiul Mar 25, 2023
399a434
Move comments about snapshot widths
luixxiul Mar 25, 2023
fa97ee6
Check audio player's rendering and its button's visibility
luixxiul Mar 25, 2023
725d020
Add checkPlayerVisibility()
luixxiul Mar 25, 2023
82e4804
Take snapshots of the small player
luixxiul Mar 26, 2023
bcf8634
Edit snapshot name
luixxiul Mar 26, 2023
376ef1b
Use cy.closeDialog()
luixxiul Mar 26, 2023
6d559f0
Check player visibility on ThreadView
luixxiul Mar 26, 2023
1e0560c
Manage widths with variables
luixxiul Mar 26, 2023
39cdbe3
Merge branch 'develop' into test-audioplayer
luixxiul Mar 26, 2023
8ff182a
Remove 'takeSnapshotTimeline'
luixxiul Mar 26, 2023
b148eb8
Update cypress/e2e/audio-player/audio-player.spec.ts
luixxiul Mar 27, 2023
f4a0ee5
Update cypress/e2e/audio-player/audio-player.spec.ts
luixxiul Mar 27, 2023
e8094bd
Update cypress/e2e/audio-player/audio-player.spec.ts
luixxiul Mar 27, 2023
6b496e8
Edit comments
luixxiul Mar 27, 2023
98dd473
Remove an obsolete comment
luixxiul Mar 27, 2023
1a0fde5
Remove a command to set a layout value
luixxiul Mar 27, 2023
1b279fd
Remove a command to enable use_system_theme
luixxiul Mar 27, 2023
698f443
Revert "Remove a command to enable use_system_theme"
luixxiul Mar 29, 2023
437ee52
Edit a comment - disable system theme
luixxiul Mar 29, 2023
a59586f
Merge branch 'develop' of https://github.com/matrix-org/matrix-react-…
luixxiul Mar 31, 2023
555f5de
Edit a comment
luixxiul Apr 1, 2023
cdc77d6
Remove an assertion about the audio player being rendered
luixxiul Apr 1, 2023
946b330
Edit a test on a thread
luixxiul Apr 1, 2023
c581aae
Use Cypress Testing Library
luixxiul Mar 31, 2023
6969e5a
Use existing functions in favor of visitRoom()
luixxiul Apr 1, 2023
af07043
Improve the test flow - checking on the high contrast theme
luixxiul Apr 1, 2023
04ad2f8
Simplify and improve the widths setting of snapshots
luixxiul Apr 1, 2023
a20648f
Improve takeSnapshots
luixxiul Apr 1, 2023
dd1d306
Improve the test - checking a reply and a reply chain
luixxiul Apr 1, 2023
6495655
Remove redundant within()
luixxiul Apr 1, 2023
7774d44
Add audio files to make the test check files more strictly
luixxiul Apr 1, 2023
5dc2463
Simplify the test a little bit by removing within()
luixxiul Apr 1, 2023
3c5bb25
Edit a comment
luixxiul Apr 1, 2023
7488d88
Create uploadAndTakeSnapshots()
luixxiul Apr 1, 2023
a9fc678
Improve the test - download
luixxiul Apr 1, 2023
21d0798
lint
luixxiul Apr 1, 2023
b11f30d
theme -> detail
luixxiul Apr 1, 2023
7019c86
Merge branch 'develop' of https://github.com/matrix-org/matrix-react-…
luixxiul Apr 1, 2023
b176a22
Iterate - remove uploadAndTakeSnapshots
luixxiul Apr 2, 2023
50a0c1a
Iterate - remove within()
luixxiul Apr 2, 2023
0175351
Iterate - remove redundant wrappers
luixxiul Apr 2, 2023
e2e08b3
Output log for IRC layout
luixxiul Apr 2, 2023
f3fc364
Remove redundant comments
luixxiul Apr 2, 2023
b38ee4d
Edit log()
luixxiul Apr 2, 2023
df5f2b9
Chain commands
luixxiul Apr 2, 2023
bf296a4
Edit comments
luixxiul Apr 2, 2023
d95b153
Merge branch 'develop' of https://github.com/matrix-org/matrix-react-…
luixxiul Apr 3, 2023
c1baa6d
Remove unused injectAxe()
luixxiul Apr 3, 2023
c0d9733
Merge branch 'develop' into test-audioplayer
luixxiul Apr 5, 2023
7d0df71
Add a comment about 'monospace'
luixxiul Apr 5, 2023
e1ae92b
Edit a comment
luixxiul Apr 5, 2023
febe45b
Merge branch 'develop' into test-audioplayer
richvdh Apr 5, 2023
4c9c613
Merge branch 'develop' into test-audioplayer
luixxiul Apr 5, 2023
450a48f
Merge branch 'develop' into test-audioplayer
t3chguy Apr 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
388 changes: 388 additions & 0 deletions cypress/e2e/audio-player/audio-player.spec.ts
View file
Open in desktop

Large diffs are not rendered by default.

Binary file added cypress/fixtures/1sec-long-name-audio-file.ogg
View file
Open in desktop
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test result: https://www.virustotal.com/gui/url/7491184fee27fb2611212c7fff4ed5919b5b7a9d840fad00f5d0e8ea0fef78fa?nocache=1

Binary file not shown.
Binary file added cypress/fixtures/upload-first.ogg
View file
Open in desktop
Binary file not shown.
Binary file added cypress/fixtures/upload-second.ogg
View file
Open in desktop
Binary file not shown.
Binary file added cypress/fixtures/upload-third.ogg
View file
Open in desktop
Binary file not shown.
4 changes: 2 additions & 2 deletions src/components/views/settings/ThemeChoicePanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ export default class ThemeChoicePanel extends React.Component<IProps, IState> {
(findHighContrastTheme(this.state.theme) || isHighContrastTheme(this.state.theme))
) {
return (
<div>
<div data-testid="theme-choice-panel-highcontrast">
<StyledCheckbox
checked={isHighContrastTheme(this.state.theme)}
onChange={(e) => this.highContrastThemeChanged(e.target.checked)}
Expand Down Expand Up @@ -248,7 +248,7 @@ export default class ThemeChoicePanel extends React.Component<IProps, IState> {
<div className="mx_SettingsTab_section mx_ThemeChoicePanel">
<span className="mx_SettingsTab_subheading">{_t("Theme")}</span>
{systemThemeSection}
<div className="mx_ThemeSelectors">
<div className="mx_ThemeSelectors" data-testid="theme-choice-panel-selectors">
<StyledRadioGroup
name="theme"
definitions={orderedThemes.map((t) => ({
Expand Down
1 change: 1 addition & 0 deletions test/components/views/settings/__snapshots__/ThemeChoicePanel-test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ exports[`ThemeChoicePanel renders the theme choice UI 1`] = `
</span>
<div
class="mx_ThemeSelectors"
data-testid="theme-choice-panel-selectors"
>
<label
class="mx_StyledRadioButton mx_ThemeSelector_light mx_StyledRadioButton_disabled mx_StyledRadioButton_outlined"
Expand Down