Update spaces.spec.ts - use Cypress Testing Library
#10620
Conversation
github-actions
bot
added
Z-Community-PR
| <AccessibleButton | ||
| className={classNames("mx_SpaceCreateMenuType", className)} | ||
| onClick={onClick} | ||
| aria-label={_t("Create a %(publicOrPrivate)s space", { |
There was a problem hiding this comment.
Why is the aria label different from the button text contents? This button already has a good accessible name. Our testing utils should be flexible enough to select buttons in multiple ways as needed.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
| @@ -62,6 +63,7 @@ const SpacePublicShare: React.FC<IProps> = ({ space, onFinished }) => { | |||
| if (onFinished) onFinished(); | |||
| showRoomInviteDialog(space.roomId); | |||
| }} | |||
| aria-label={_t("Invite people")} | |||
There was a problem hiding this comment.
Why can't you use the text in the button itself to select this for tests?
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
luixxiul
changed the title
spaces.spec.ts - use Cypress Testing Library and set unique aria-labelspaces.spec.ts - use Cypress Testing Library
| cy.get(".mx_SpacePanel:not(.collapsed)").should("exist"); | ||
| cy.findByRole("tree", { name: "Spaces" }).within(() => { | ||
| // This finds the expand button with the class name "mx_SpaceButton_toggleCollapse". Note there is another | ||
| // button with the same name with different class name "mx_SpacePanel_toggleCollapse". |
There was a problem hiding this comment.
This comment is a bit confusing, is the second class meant to be different?
There was a problem hiding this comment.
It is intended to note that there are two buttons whose name is Expand and it is not possible to select the proper one without specifying with findByRole("tree", { name: "Spaces" }).within.
For element-hq/element-web#25033
This PR update
spaces.spec.tsby using Cypress Testing Library.type: task
Signed-off-by: Suguru Hirahara luixxiul@users.noreply.github.com
Checklist
This change is marked as an internal change (Task), so will not be included in the changelog.