Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Render custom images in reactions #11087

Merged
merged 12 commits into from
Sep 1, 2023
Merged

Render custom images in reactions #11087

merged 12 commits into from
Sep 1, 2023

Commits on Aug 16, 2023

  1. Add support for rendering custom emojis in reactions 

    Signed-off-by: Sumner Evans <sumner@beeper.com>
    @tulir @sumnerevans
    tulir authored and sumnerevans committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    56646ec View commit details
    Browse the repository at this point in the history

  2. Include custom reaction short names in tooltips 

    Signed-off-by: Sumner Evans <sumner@beeper.com>
    @tulir @sumnerevans
    tulir authored and sumnerevans committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    a4b8ae7 View commit details
    Browse the repository at this point in the history

  3. Use custom reaction shortcode for accessibility 

    This uses the shortcode in the following places:

* The aria-label of the reaction buttons
* The alt text for the reaction image

Signed-off-by: Sumner Evans <sumner@beeper.com>
    @sumnerevans
    sumnerevans committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    4df35a5 View commit details
    Browse the repository at this point in the history

  4. Remove explicit instantiation of customReactionName variable and ad… 

    …d types

Co-authored-by: Šimon Brandner <simon.bra.ag@gmail.com>
    @sumnerevans @SimonBrandner
    sumnerevans and SimonBrandner committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    c0822da View commit details
    Browse the repository at this point in the history

  5. Put custom reaction images behind a labs flag 

    Signed-off-by: Sumner Evans <sumner@beeper.com>
    @sumnerevans
    sumnerevans committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    40f0379 View commit details
    Browse the repository at this point in the history

  6. Use UnstableValue for finding the shortcode 

    Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Sumner Evans <sumner@beeper.com>
    @sumnerevans @t3chguy
    sumnerevans and t3chguy committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    c054777 View commit details
    Browse the repository at this point in the history

  7. Move calculation of whether to render custom reaction images up to Re… 

    …actionRow

Signed-off-by: Sumner Evans <sumner@beeper.com>
    @sumnerevans
    sumnerevans committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    f7d7a8c View commit details
    Browse the repository at this point in the history

  8. Make alt text more friendly when custom reaction doesn't have shortcode 

    Signed-off-by: Sumner Evans <sumner@beeper.com>
    @sumnerevans
    sumnerevans committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    3045c3f View commit details
    Browse the repository at this point in the history

  9. Add test for ReactionsRowButton 

    Signed-off-by: Sumner Evans <sumner@beeper.com>
    @sumnerevans
    sumnerevans committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    53e9eda View commit details
    Browse the repository at this point in the history

  10. Apply suggestions from code review 

    Co-authored-by: Šimon Brandner <simon.bra.ag@gmail.com>
    @sumnerevans @SimonBrandner
    sumnerevans and SimonBrandner authored Aug 16, 2023
    Configuration menu
    Copy the full SHA
    1ab97d3 View commit details
    Browse the repository at this point in the history

  11. Don't use Optional 

    Signed-off-by: Sumner Evans <sumner@beeper.com>
    @sumnerevans
    sumnerevans committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    3845d29 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2023

  1. Fix ReactionsRowButton test 

    Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Sumner Evans <sumner@beeper.com>
    @sumnerevans @t3chguy
    sumnerevans and t3chguy committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    acae684 View commit details
    Browse the repository at this point in the history