This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 829
Allow Chrome page translator to translate messages in rooms #11113
Merged
richvdh
merged 9 commits into
matrix-org:develop
from
lukaszpolowczyk:lukaszpolowczyk/feat/support-message-translation-in-chat
Jul 25, 2024
+136
−46
Merged
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
63a68af
support message translation in chat
lukaszpolowczyk 579d856
Merge branch 'develop' into lukaszpolowczyk/feat/support-message-tran…
richvdh 81b8d61
Merge branch 'develop' into lukaszpolowczyk/feat/support-message-tran…
richvdh 3ca5c53
Merge branch 'matrix-org:develop' into lukaszpolowczyk/feat/support-m…
lukaszpolowczyk a915f5f
Update src/HtmlUtils.tsx
richvdh ea77f26
Merge branch 'develop' into lukaszpolowczyk/feat/support-message-tran…
richvdh 96753d3
Merge branch 'develop' into lukaszpolowczyk/feat/support-message-tran…
richvdh 450becf
update snapshots
richvdh c0ae9fa
Convert TextualBody-test to use snapshots
richvdh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please could you add a comment explaining a bit more about what this does, and why it is necessary? Surely it isn't normally necessary to mark things for translation explicitly?
Do I understand correctly that this is overriding a
notranslate
class somewhere else? Please say that in a comment if so.Basically: imagine you are a developer reading this code for the first time, without the benefit of having read all of the conversation on element-hq/element-web#25594, and that you are trying to understand what this is for.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@richvdh Yes.
The entire application currently has translation disabled using the
notranslate
class placed in thediv#matrixchat
element.The
translate
class overrides thenotranslate
class that is in this element's ancestor.