This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Compound Typography pass regression fixes #11189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
germain-gg
added
the
T-Task
nadonomy
suggested changes
Jul 4, 2023
There was a problem hiding this comment.
From DM discussion, for PR posterity:
- To revert usernames back from sm to md, as this introduces strain without materially improving the timeline legibility or hierarchy
- Nit: Text in room tiles with previews isn't vertically centred
- Nit: Room name & text preview in room tiles would benefit from more negative space - 4px extra margin in browser dev tools helps, whatever implementation plays nice with font scaling works
|
@germain-gg looking much better, thx! one small issue - it looks like the descenders on message previews are clipping: 
|
nadonomy
approved these changes
Jul 4, 2023
There was a problem hiding this comment.
@germain-gg LGTM now, thx for the tweaks!
If a message preview has no descenders the alignment can look off, but suggest we solve this when we're properly componentising the room list in due course.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Worked on this with @nadonomy
Introduced by #11103
Checklist
This change is marked as an internal change (Task), so will not be included in the changelog.