Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Tests for read/unread status #11301

Merged
merged 39 commits into from
Aug 10, 2023
Merged

Tests for read/unread status #11301

merged 39 commits into from
Aug 10, 2023

Conversation

andybalaam
Copy link
Member

@andybalaam andybalaam commented Jul 19, 2023

Fixes element-hq/element-web#25449


This change is marked as an internal change (Task), so will not be included in the changelog.

@andybalaam andybalaam force-pushed the andybalaam/read-status-tests branch from cf55c95 to e6b5b12 Compare July 21, 2023 10:06
@andybalaam andybalaam added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Jul 21, 2023
Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clearing my review req

@t3chguy t3chguy requested review from a team and richvdh and removed request for a team August 8, 2023 09:40
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay tests!

cypress/e2e/read-receipts/high-level.spec.ts Show resolved Hide resolved
cypress/support/views.ts Show resolved Hide resolved
cypress/e2e/read-receipts/high-level.spec.ts Outdated Show resolved Hide resolved
cypress/e2e/read-receipts/high-level.spec.ts Outdated Show resolved Hide resolved
cypress/e2e/read-receipts/high-level.spec.ts Show resolved Hide resolved
cypress/e2e/read-receipts/high-level.spec.ts Show resolved Hide resolved
cypress/e2e/read-receipts/high-level.spec.ts Outdated Show resolved Hide resolved
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much clearer, still a couple of things

cypress/e2e/read-receipts/high-level.spec.ts Outdated Show resolved Hide resolved
cypress/e2e/read-receipts/high-level.spec.ts Show resolved Hide resolved
cypress/e2e/read-receipts/high-level.spec.ts Show resolved Hide resolved
cypress/support/views.ts Show resolved Hide resolved
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

cypress/e2e/read-receipts/high-level.spec.ts Outdated Show resolved Hide resolved
@t3chguy t3chguy removed this pull request from the merge queue due to a manual request Aug 10, 2023
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
@t3chguy t3chguy added this pull request to the merge queue Aug 10, 2023
Merged via the queue into develop with commit c55400d Aug 10, 2023
@t3chguy t3chguy deleted the andybalaam/read-status-tests branch August 10, 2023 13:30
@andybalaam andybalaam self-assigned this Aug 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test cases for stuck unreads and notifs
3 participants