Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Migrate credits translations to IDs #11453

Merged
merged 45 commits into from
Aug 25, 2023
Merged

Migrate credits translations to IDs #11453

merged 45 commits into from
Aug 25, 2023

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Aug 22, 2023

For element-hq/element-web#25608

./node_modules/matrix-web-i18n/scripts/rekey.js "The <photo>default cover photo</photo> is © <author>Jesús Roncero</author> used under the terms of <terms>CC-BY-SA 4.0</terms>." "credits|default_cover_photo"
./node_modules/matrix-web-i18n/scripts/rekey.js "The <colr>twemoji-colr</colr> font is © <author>Mozilla Foundation</author> used under the terms of <terms>Apache 2.0</terms>." "credits|twemoji_colr"
./node_modules/matrix-web-i18n/scripts/rekey.js "The <twemoji>Twemoji</twemoji> emoji art is © <author>Twitter, Inc and other contributors</author> used under the terms of <terms>CC-BY 4.0</terms>." "credits|twemoji"

This change is marked as an internal change (Task), so will not be included in the changelog.

@t3chguy t3chguy added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Aug 22, 2023
@t3chguy t3chguy self-assigned this Aug 22, 2023
Copy link
Contributor

@SimonBrandner SimonBrandner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the removal of new lines at the end of the i18n files intentional?

Otherwise LGTM

@t3chguy
Copy link
Member Author

t3chguy commented Aug 23, 2023

Is the removal of new lines at the end of the i18n files intentional?

Nope but these files are prettierignored which is annoying, have undone it but now instead it added more newlines to other files! 🙃

@t3chguy t3chguy added this pull request to the merge queue Aug 25, 2023
Merged via the queue into develop with commit 9d417ce Aug 25, 2023
19 checks passed
@t3chguy t3chguy deleted the t3chguy/localazy-key-2 branch August 25, 2023 11:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants