-
-
Notifications
You must be signed in to change notification settings - Fork 833
Allow configuration of a default rendezvous server for use with Sign in with QR #11638
Conversation
1595d36
to
c01492c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this have a user opt-in like the default STUN server does? What about privacy/terms acceptance for GDPR/etc
…om/matrix-org/matrix-react-sdk into hughns/qr-signin-default-rz-server
The assumed consent model is that whomever deploys and operates a build of Element Web that makes use of this config option would need to ensure that their terms of service cover such a use case. The immediate use case is where a homeserver operator is also providing the Element Web installation. Therefore, the appropriate consent is handled the same as if the rendezvous server is built-in to the homeserver. This is because the As such, I don't believe an opt-in mechanism is needed at this time. |
But that isn't how other things work in the Element Web client. The person deploying Element Web chooses the HS and can even enforce it by use of https://github.com/vector-im/element-web/blob/develop/docs/config.md Element Web running entirely on the user's device means it doesn't need its own privacy/terms, but as soon as you're reaching out to a server that changes.
What protections are there to ensure the rz and hs are of the same operator? Given that HS can be changed (even if |
I think at the very least it'd need to be a map akin to |
I will refactor to use this approach. |
Such an approach is also considered tech debt and will likely need a chat with the WAT whether its appropriate for the record. Why isn't this done via a Synapse plugin or similar which listens to the RZ routes and advertises support via the versions/capabilities API? |
Making draft as the feedback from the maintainer as that solution is unacceptable. |
Closing as we've aligned on pursuing #11655 instead. |
Checklist
Here's what your changelog entry will look like:
✨ Features