Target specific thread name to unflake redaction tests

[andybalaam]

Ensure that when we ask to open a thread called "Root2", we don't accidentally open a thread called "Root" that has "2 unread replies" in it.

Part of element-hq/element-web#25449

---

This change is marked as an internal change (Task), so will not be included in the changelog.

[richvdh]

don't quite get this. If the problem is that we match "Root2" when we look for "Root", won't we also match "SecondRoot"?

[andybalaam]

don't quite get this. If the problem is that we match "Root2" when we look for "Root", won't we also match "SecondRoot"?

That is a very good question. The symptom I saw was that we appeared to match "Root" when we searched for "Root2".

I ran the test 10 times after the change and it works, but I agree that it would be very nice to know why.

[andybalaam]

don't quite get this. If the problem is that we match "Root2" when we look for "Root", won't we also match "SecondRoot"?

That is a very good question. The symptom I saw was that we appeared to match "Root" when we searched for "Root2".

I ran the test 10 times after the change and it works, but I agree that it would be very nice to know why.

Thanks to @germain-gg we figured out that the cy.contains call is matching a thread root called "Root", followed by the string "2 replies". I think the correct fix is to stop using contains and be more specific, so I will try that.

[richvdh]

I wouldn't have minded a comment explaining the need for caution here, but sure