Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Playwright: Enable skipped tests in reactions.spec.ts #12019

Merged
merged 2 commits into from
Dec 8, 2023
Merged

Playwright: Enable skipped tests in reactions.spec.ts #12019

merged 2 commits into from
Dec 8, 2023

Conversation

florianduros
Copy link
Contributor

@florianduros florianduros commented Dec 8, 2023 •
edited
Loading

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

Part of element-hq/element-web#25449

This change is marked as an internal change (Task), so will not be included in the changelog.

@florianduros florianduros added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Dec 8, 2023
@florianduros florianduros marked this pull request as ready for review December 8, 2023 15:00
@florianduros florianduros requested a review from a team as a code owner December 8, 2023 15:00
andybalaam
andybalaam approved these changes Dec 8, 2023
View reviewed changes
Copy link
Member

@andybalaam andybalaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@florianduros florianduros added this pull request to the merge queue Dec 8, 2023
Merged via the queue into develop with commit 75500b6 Dec 8, 2023
40 checks passed
@florianduros florianduros deleted the florianduros/unread/enabled-skipped-reactions branch December 8, 2023 16:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andybalaam andybalaam andybalaam approved these changes

@dbkr dbkr Awaiting requested review from dbkr dbkr is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@florianduros @andybalaam