Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Refactor element call lobby + skip lobby #12057

Merged
merged 58 commits into from
Jan 29, 2024
Merged

Refactor element call lobby + skip lobby #12057

merged 58 commits into from
Jan 29, 2024

Commits on Dec 14, 2023

  1. Refactor ElementCall to use the widget lobby. 

     - expose skip lobby
 - use the widget.data to build the widget url

Signed-off-by: Timo K <toger5@hotmail.de>
    @toger5
    toger5 committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    9bca273 View commit details
    Browse the repository at this point in the history

  2. Use shiftKey click to skip the lobby 

    Signed-off-by: Timo K <toger5@hotmail.de>
    @toger5
    toger5 committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    6d5ac0b View commit details
    Browse the repository at this point in the history

  3. remove Lobby component 

    Signed-off-by: Timo K <toger5@hotmail.de>
    @toger5
    toger5 committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    8ed0454 View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2023

  1. update tests + remove EW lobby related tests 

    Signed-off-by: Timo K <toger5@hotmail.de>
    @toger5
    toger5 committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    2518d56 View commit details
    Browse the repository at this point in the history

  2. remove lobby device button tests 

    Signed-off-by: Timo K <toger5@hotmail.de>
    @toger5
    toger5 committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    01d63df View commit details
    Browse the repository at this point in the history

  3. i18n 

    Signed-off-by: Timo K <toger5@hotmail.de>
    @toger5
    toger5 committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    b12d176 View commit details
    Browse the repository at this point in the history

  4. use voip participant label 

    Signed-off-by: Timo K <toger5@hotmail.de>
    @toger5
    toger5 committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    448403c View commit details
    Browse the repository at this point in the history

  5. update tests 

    Signed-off-by: Timo K <toger5@hotmail.de>
    @toger5
    toger5 committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    ce76630 View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2023

  1. Merge branch 'develop' into toger5/skip_lobby

    @toger5
    toger5 committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    2907373 View commit details
    Browse the repository at this point in the history

Commits on Dec 27, 2023

  1. fix rounded corners in pip 

    Signed-off-by: Timo K <toger5@hotmail.de>
    @toger5
    toger5 committed Dec 27, 2023
    Configuration menu
    Copy the full SHA
    f01b155 View commit details
    Browse the repository at this point in the history

  2. allow joining call in legacy room header (without banner) 

    Signed-off-by: Timo K <toger5@hotmail.de>
    @toger5
    toger5 committed Dec 27, 2023
    Configuration menu
    Copy the full SHA
    68808fb View commit details
    Browse the repository at this point in the history

  3. Introduce new connection states for calls. 

    And use them for integrated lobby.

Signed-off-by: Timo K <toger5@hotmail.de>
    @toger5
    toger5 committed Dec 27, 2023
    Configuration menu
    Copy the full SHA
    821211a View commit details
    Browse the repository at this point in the history

  4. New room header call join 

    Fix broken top container element call.

Signed-off-by: Timo K <toger5@hotmail.de>
    @toger5
    toger5 committed Dec 27, 2023
    Configuration menu
    Copy the full SHA
    d1e3a6d View commit details
    Browse the repository at this point in the history

  5. i18n 

    Signed-off-by: Timo K <toger5@hotmail.de>
    @toger5
    toger5 committed Dec 27, 2023
    Configuration menu
    Copy the full SHA
    1a2a2c9 View commit details
    Browse the repository at this point in the history

  6. Fix closing element call in lobby view. 

    (should destroy call if there the user never managed to connect (not clicked join in lobby)

Signed-off-by: Timo K <toger5@hotmail.de>
    @toger5
    toger5 committed Dec 27, 2023
    Configuration menu
    Copy the full SHA
    24d39b8 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'develop' into toger5/skip_lobby 

    Signed-off-by: Timo K <toger5@hotmail.de>
    @toger5
    toger5 committed Dec 27, 2023
    Configuration menu
    Copy the full SHA
    4d99794 View commit details
    Browse the repository at this point in the history

  8. all cases for connection state 

    Signed-off-by: Timo K <toger5@hotmail.de>
    @toger5
    toger5 committed Dec 27, 2023
    Configuration menu
    Copy the full SHA
    54f39a9 View commit details
    Browse the repository at this point in the history

  9. add correct LiveContentSummary labels 

    Signed-off-by: Timo K <toger5@hotmail.de>
    @toger5
    toger5 committed Dec 27, 2023
    Configuration menu
    Copy the full SHA
    628ea01 View commit details
    Browse the repository at this point in the history

Commits on Dec 28, 2023

  1. Theme widget loading (no rounded corner) 

    destroy call when switching room while a call is loading.

Signed-off-by: Timo K <toger5@hotmail.de>
    @toger5
    toger5 committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    8ccb991 View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2024

  1. temp 

    Signed-off-by: Timo K <toger5@hotmail.de>
    @toger5
    toger5 committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    3fed014 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into toger5/skip_lobby 

    Signed-off-by: Timo K <toger5@hotmail.de>
    @toger5
    toger5 committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    7e83add View commit details
    Browse the repository at this point in the history

  3. usei view room dispatcher instead of emitter 

    Signed-off-by: Timo K <toger5@hotmail.de>
    @toger5
    toger5 committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    a2fcfc0 View commit details
    Browse the repository at this point in the history

  4. tidy up 

    Signed-off-by: Timo K <toger5@hotmail.de>
    @toger5
    toger5 committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    521ac24 View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2024

  1. returnToLobby + remove StartCallView 

    Signed-off-by: Timo K <toger5@hotmail.de>
    @toger5
    toger5 committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    d658c56 View commit details
    Browse the repository at this point in the history

  2. comment cleanup 

    Signed-off-by: Timo K <toger5@hotmail.de>
    @toger5
    toger5 committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    9c117cf View commit details
    Browse the repository at this point in the history

  3. disconnect ongoing calls before making widget sticky. 

    Signed-off-by: Timo K <toger5@hotmail.de>
    @toger5
    toger5 committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    29a69ed View commit details
    Browse the repository at this point in the history

  4. linter + jitsi as videoChannel 

    Signed-off-by: Timo K <toger5@hotmail.de>
    @toger5
    toger5 committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    8548714 View commit details
    Browse the repository at this point in the history

  5. stickyPromise type 

    Signed-off-by: Timo K <toger5@hotmail.de>
    @toger5
    toger5 committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    c91221f View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2024

  1. fix legacy call (jistsi, cisco, bbb) reopen 

    when clicking call button

Signed-off-by: Timo K <toger5@hotmail.de>
    @toger5
    toger5 committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    5160df5 View commit details
    Browse the repository at this point in the history

  2. fix tests and connect resolves 

    Signed-off-by: Timo K <toger5@hotmail.de>
    @toger5
    toger5 committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    9f68561 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'develop' into toger5/skip_lobby

    @toger5
    toger5 committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    fcbd482 View commit details
    Browse the repository at this point in the history

  4. fix "waits for messaging when connecting" test 

    Signed-off-by: Timo K <toger5@hotmail.de>
    @toger5
    toger5 committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    baf7669 View commit details
    Browse the repository at this point in the history

  5. Allow to skip awaiting Call session events. 

    This option is used in tests to spare mocking the
events emitted when EC updates the room state

Signed-off-by: Timo K <toger5@hotmail.de>
    @toger5
    toger5 committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    201e155 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2024

  1. add sticky test 

    Signed-off-by: Timo K <toger5@hotmail.de>
    @toger5
    toger5 committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    0532c42 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2024

  1. add test for looby tile rendering 

    Signed-off-by: Timo K <toger5@hotmail.de>
    @toger5
    toger5 committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    90a12d8 View commit details
    Browse the repository at this point in the history

  2. fix flaky test 

    Signed-off-by: Timo K <toger5@hotmail.de>
    @toger5
    toger5 committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    dab8e1f View commit details
    Browse the repository at this point in the history

  3. add reconnect after disconnect test (video room) 

    Signed-off-by: Timo K <toger5@hotmail.de>
    @toger5
    toger5 committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    9bb4989 View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2024

  1. add shift click test to call toast 

    Signed-off-by: Timo K <toger5@hotmail.de>
    @toger5
    toger5 committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    64bc219 View commit details
    Browse the repository at this point in the history

  2. test for allowVoipWithNoMedia in widget url 

    Signed-off-by: Timo K <toger5@hotmail.de>
    @toger5
    toger5 committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    e20ea5e View commit details
    Browse the repository at this point in the history

  3. fix e2e tests to search for the right element 

    Signed-off-by: Timo K <toger5@hotmail.de>
    @toger5
    toger5 committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    8b2df91 View commit details
    Browse the repository at this point in the history

  4. destroy call after test so next test does not fail 

    Signed-off-by: Timo K <toger5@hotmail.de>
    @toger5
    toger5 committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    1c6a11b View commit details
    Browse the repository at this point in the history

  5. new call test (connection failed) 

    Signed-off-by: Timo K <toger5@hotmail.de>
    @toger5
    toger5 committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    b298271 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2024

  1. reset to real timers 

    Signed-off-by: Timo K <toger5@hotmail.de>
    @toger5
    toger5 committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    820e330 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into toger5/skip_lobby

    @toger5
    toger5 committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    b4d3da7 View commit details
    Browse the repository at this point in the history

  3. dont use skipSessionAwait for tests 

    Signed-off-by: Timo K <toger5@hotmail.de>
    @toger5
    toger5 committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    59ddba7 View commit details
    Browse the repository at this point in the history

  4. code quality (sonar) 

    Signed-off-by: Timo K <toger5@hotmail.de>
    @toger5
    toger5 committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    967930a View commit details
    Browse the repository at this point in the history

  5. refactor call.disconnect tests (dont use skipSessionAwait) 

    Signed-off-by: Timo K <toger5@hotmail.de>
    @toger5
    toger5 committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    33cf605 View commit details
    Browse the repository at this point in the history

  6. miscellaneous cleanup 

    Signed-off-by: Timo K <toger5@hotmail.de>
    @toger5
    toger5 committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    843079f View commit details
    Browse the repository at this point in the history

  7. only send call notify after the call has been joined (not when just o… 

    …pening the lobby)

Signed-off-by: Timo K <toger5@hotmail.de>
    @toger5
    toger5 committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    b9bf61a View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2024

  1. update call notify tests to expect notify on connect. 

    Not on widget creation.

Signed-off-by: Timo K <toger5@hotmail.de>
    @toger5
    toger5 committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    368b3ed View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2024

  1. Update playwright/e2e/room/room-header.spec.ts 

    Co-authored-by: Robin <robin@robin.town>
    @toger5 @robintown
    toger5 and robintown authored Jan 25, 2024
    Configuration menu
    Copy the full SHA
    83e0374 View commit details
    Browse the repository at this point in the history

  2. Update src/components/views/voip/CallView.tsx 

    Co-authored-by: Robin <robin@robin.town>
    @toger5 @robintown
    toger5 and robintown authored Jan 25, 2024
    Configuration menu
    Copy the full SHA
    9d61bc4 View commit details
    Browse the repository at this point in the history

  3. review 

    rename connect -> start
isVideoRoom not dependant on feature flags
rename allOtherCallsDisconnected -> disconnectAllOtherCalls

Signed-off-by: Timo K <toger5@hotmail.de>
    @toger5
    toger5 committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    09344a5 View commit details
    Browse the repository at this point in the history

  4. check for EC widget 

    Signed-off-by: Timo K <toger5@hotmail.de>
    @toger5
    toger5 committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    7673e5f View commit details
    Browse the repository at this point in the history

  5. dep array 

    Signed-off-by: Timo K <toger5@hotmail.de>
    @toger5
    toger5 committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    f97fb9b View commit details
    Browse the repository at this point in the history

  6. rename in spyOn 

    Signed-off-by: Timo K <toger5@hotmail.de>
    @toger5
    toger5 committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    f25c2ea View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2024

  1. Merge branch 'develop' into toger5/skip_lobby

    @toger5
    toger5 authored Jan 29, 2024
    Configuration menu
    Copy the full SHA
    91f8075 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into toger5/skip_lobby

    @toger5
    toger5 authored Jan 29, 2024
    Configuration menu
    Copy the full SHA
    e34790d View commit details
    Browse the repository at this point in the history