Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Accessibility improvements around aria-labels and tooltips #12062

Merged
merged 32 commits into from
Jan 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
63fa415
Prevent Cypress typechecking react-sdk components without strict mode
t3chguy Dec 14, 2023
1b09a8c
Update global.d.ts
t3chguy Dec 14, 2023
65b0dc5
Switch AccessibleButton and derivatives to using `forwardRef`
t3chguy Dec 14, 2023
1c59d58
Add missing ref={ref}
t3chguy Dec 14, 2023
1c1469e
Iterate
t3chguy Dec 14, 2023
0515c40
Ensure RefObjects are used consistently
t3chguy Dec 14, 2023
aca53a7
Merge branch 'develop' into t3chguy/cr/157-2
t3chguy Dec 15, 2023
6dcccf9
Re-add WysiwygAutocomplete displayname
t3chguy Dec 15, 2023
c2c32eb
Fix forwardRef types
t3chguy Dec 15, 2023
3699d29
Add comments
t3chguy Dec 15, 2023
612208c
Remove unused export
t3chguy Dec 15, 2023
eb9cd12
Readd comment
t3chguy Dec 15, 2023
b4444e0
Merge remote-tracking branch 'origin/t3chguy/cr/157-2' into t3chguy/c…
t3chguy Dec 15, 2023
8f1a68a
Accessibility improvements around aria-labels and tooltips
t3chguy Dec 15, 2023
5811f54
Tweak copy
t3chguy Dec 15, 2023
8d3a6ec
Iterate types & comments
t3chguy Dec 18, 2023
166b55b
Merge branch 't3chguy/cr/157-2' into t3chguy/cr/157-3
t3chguy Dec 18, 2023
a90514d
i18n
t3chguy Dec 18, 2023
0861908
Update snapshots
t3chguy Dec 18, 2023
757f75f
Apply suggestions from code review
t3chguy Dec 19, 2023
e2ec5ff
Merge branch 'develop' of github.com:matrix-org/matrix-react-sdk into…
t3chguy Dec 20, 2023
596bec8
Merge remote-tracking branch 'origin/t3chguy/cr/157-2' into t3chguy/c…
t3chguy Dec 20, 2023
e972ed4
Merge branch 'develop' of github.com:matrix-org/matrix-react-sdk into…
t3chguy Dec 20, 2023
807a7ab
Add comment
t3chguy Dec 20, 2023
cd94693
Iterate
t3chguy Dec 20, 2023
afcef5a
Improve comment
t3chguy Dec 20, 2023
4610654
Merge branch 't3chguy/cr/157-2' of github.com:matrix-org/matrix-react…
t3chguy Dec 20, 2023
b4ce004
Merge branch 'develop' into t3chguy/cr/157-2
t3chguy Dec 20, 2023
b552529
Merge branch 't3chguy/cr/157-2' into t3chguy/cr/157-3
t3chguy Dec 20, 2023
5044827
Merge branch 'develop' of github.com:matrix-org/matrix-react-sdk into…
t3chguy Jan 5, 2024
8ab7477
Merge remote-tracking branch 'origin/t3chguy/cr/157-3' into t3chguy/c…
t3chguy Jan 5, 2024
410e533
Prettier & i18n
t3chguy Jan 5, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/components/views/audio_messages/SeekBar.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ import React, { ChangeEvent, CSSProperties, ReactNode } from "react";
import { PlaybackInterface } from "../../../audio/Playback";
import { MarkedExecution } from "../../../utils/MarkedExecution";
import { percentageOf } from "../../../utils/numbers";
import { _t } from "../../../languageHandler";

interface IProps {
// Playback instance to render. Cannot change during component lifecycle: create
Expand Down Expand Up @@ -112,6 +113,7 @@ export default class SeekBar extends React.PureComponent<IProps, IState> {
step={0.001}
style={{ "--fillTo": this.state.percentage } as ISeekCSS}
disabled={this.props.disabled}
aria-label={_t("a11y|seek_bar_label")}
/>
);
}
Expand Down
1 change: 1 addition & 0 deletions src/components/views/rooms/RoomHeader.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -273,6 +273,7 @@ export default function RoomHeader({
size="20px"
overflow={false}
viewUserOnClick={false}
tooltipLabel={_t("room|header_face_pile_tooltip")}
>
{formatCount(memberCount)}
</FacePile>
Expand Down
2 changes: 2 additions & 0 deletions src/i18n/strings/en_EN.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
"recent_rooms": "Recent rooms",
"room_name": "Room %(name)s",
"room_status_bar": "Room status bar",
"seek_bar_label": "Audio seek bar",
"unread_messages": "Unread messages.",
"user_menu": "User menu"
},
Expand Down Expand Up @@ -1946,6 +1947,7 @@
"video_call_ec_layout_spotlight": "Spotlight",
"video_room_view_chat_button": "View chat timeline"
},
"header_face_pile_tooltip": "Toggle member list",
"header_untrusted_label": "Untrusted",
"inaccessible": "This room or space is not accessible at this time.",
"inaccessible_name": "%(roomName)s is not accessible at this time.",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
exports[`SeekBar when rendering a SeekBar and the playback proceeds should render as expected 1`] = `
<div>
<input
aria-label="Audio seek bar"
class="mx_SeekBar"
max="1"
min="0"
Expand All @@ -18,6 +19,7 @@ exports[`SeekBar when rendering a SeekBar and the playback proceeds should rende
exports[`SeekBar when rendering a SeekBar for an empty playback should render correctly 1`] = `
<div>
<input
aria-label="Audio seek bar"
class="mx_SeekBar"
max="1"
min="0"
Expand All @@ -33,6 +35,7 @@ exports[`SeekBar when rendering a SeekBar for an empty playback should render co
exports[`SeekBar when rendering a SeekBar should render the initial position 1`] = `
<div>
<input
aria-label="Audio seek bar"
class="mx_SeekBar"
max="1"
min="0"
Expand All @@ -48,6 +51,7 @@ exports[`SeekBar when rendering a SeekBar should render the initial position 1`]
exports[`SeekBar when rendering a disabled SeekBar should render as expected 1`] = `
<div>
<input
aria-label="Audio seek bar"
class="mx_SeekBar"
disabled=""
max="1"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,7 @@ exports[`VoiceBroadcastPlaybackBody when rendering a buffering voice broadcast s
</div>
</div>
<input
aria-label="Audio seek bar"
class="mx_SeekBar"
max="1"
min="0"
Expand Down Expand Up @@ -213,6 +214,7 @@ exports[`VoiceBroadcastPlaybackBody when rendering a pause/not-live broadcast sh
</div>
</div>
<input
aria-label="Audio seek bar"
class="mx_SeekBar"
max="1"
min="0"
Expand Down Expand Up @@ -338,6 +340,7 @@ exports[`VoiceBroadcastPlaybackBody when rendering a playing broadcast in pip mo
</div>
</div>
<input
aria-label="Audio seek bar"
class="mx_SeekBar"
max="1"
min="0"
Expand Down Expand Up @@ -451,6 +454,7 @@ exports[`VoiceBroadcastPlaybackBody when rendering a playing broadcast should re
</div>
</div>
<input
aria-label="Audio seek bar"
class="mx_SeekBar"
max="1"
min="0"
Expand Down Expand Up @@ -572,6 +576,7 @@ exports[`VoiceBroadcastPlaybackBody when rendering a playing/live broadcast shou
</div>
</div>
<input
aria-label="Audio seek bar"
class="mx_SeekBar"
max="1"
min="0"
Expand Down Expand Up @@ -665,6 +670,7 @@ exports[`VoiceBroadcastPlaybackBody when rendering a stopped broadcast should re
</div>
</div>
<input
aria-label="Audio seek bar"
class="mx_SeekBar"
max="1"
min="0"
Expand Down
Loading