Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Open thread panel when thread clicked in Threads Activity Centre #12161

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

dbkr
Copy link
Member

@dbkr dbkr commented Jan 19, 2024

Hopefully this is a sensible enough way. The panel will stay open of course (ie. if you go to a different room & come back), but that's the nature of the right panel.

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

Here's what your changelog entry will look like:

🐛 Bug Fixes

  • Open thread panel when thread clicked in Threads Activity Centre (#12161).

Hopefully this is a sensible enough way. The panel will stay open of
course (ie. if you go to a different room & come back), but that's the
nature of the right panel.
@dbkr dbkr added the T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems label Jan 19, 2024
@dbkr dbkr changed the title Open thread panel when thread clicke in Threads Activity Centre Open thread panel when thread clicked in Threads Activity Centre Jan 19, 2024
@dbkr dbkr marked this pull request as ready for review January 19, 2024 16:29
@dbkr dbkr requested a review from a team as a code owner January 19, 2024 16:29
@dbkr dbkr requested review from t3chguy and florianduros and removed request for a team and t3chguy January 19, 2024 16:29
@dbkr dbkr merged commit 662c946 into florianduros/threads/pop-out-panel Jan 19, 2024
26 of 27 checks passed
@dbkr dbkr deleted the dbkr/open_threadpanel branch January 19, 2024 17:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants