Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Use the StatelessNotificationBadge component in ThreadsActivityCentre #12167

Merged

Conversation

dbkr
Copy link
Member

@dbkr dbkr commented Jan 23, 2024

and re-use the existing NotificationLevel

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@dbkr dbkr added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Jan 23, 2024
@dbkr dbkr marked this pull request as ready for review January 23, 2024 16:53
@dbkr dbkr requested a review from a team as a code owner January 23, 2024 16:53
@dbkr dbkr requested review from richvdh and florianduros and removed request for a team January 23, 2024 16:53
Copy link
Contributor

@florianduros florianduros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also remove the style related to the ThreadsActivityCentreBadge ?

@dbkr
Copy link
Member Author

dbkr commented Jan 23, 2024

ah, missed that - done

@florianduros florianduros self-requested a review January 23, 2024 17:01
@dbkr dbkr merged commit 09d2691 into florianduros/threads/pop-out-panel Jan 23, 2024
18 of 19 checks passed
@dbkr dbkr deleted the dbkr/use_stateless_notification_badge branch January 23, 2024 17:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants