Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Threads don't have activity if the room is muted #12192

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

dbkr
Copy link
Member

@dbkr dbkr commented Jan 30, 2024

This makes it match the computation in determineUnreadState. Ideally this logic should all be in one place.

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

Here's what your changelog entry will look like:

🐛 Bug Fixes

  • Threads don't have activity if the room is muted (#12192).

This makes it match the computation in determineUnreadState.
Ideally this logic should all be in one place.
@dbkr dbkr added the T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems label Jan 30, 2024
@dbkr dbkr requested a review from a team as a code owner January 30, 2024 17:43
@dbkr dbkr requested review from MidhunSureshR, robintown, florianduros, a team and t3chguy and removed request for a team, MidhunSureshR, robintown and t3chguy January 30, 2024 17:43
Copy link
Contributor

@florianduros florianduros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect thanks!

@dbkr dbkr merged commit daebac6 into florianduros/threads/pop-out-panel Jan 31, 2024
23 checks passed
@dbkr dbkr deleted the dbkr/honour_muted_unread branch January 31, 2024 09:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants