This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Use the non-deprecated importRoomKeys method on CryptoApi #12232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andybalaam
added
the
T-Task
andybalaam
force-pushed
the
andybalaam/use-nondeprecated-importroomkeys
branch
from
29a567e
to
0c56025
Compare
BillCarsonFr
approved these changes
Feb 8, 2024
| @@ -108,7 +108,7 @@ export default class ImportE2eKeysDialog extends React.Component<IProps, IState> | |||
| return MegolmExportEncryption.decryptMegolmKeyFile(arrayBuffer, passphrase); | |||
| }) | |||
| .then((keys) => { | |||
| return this.props.matrixClient.importRoomKeys(JSON.parse(keys)); | |||
| return this.props.matrixClient.getCrypto()?.importRoomKeys(JSON.parse(keys)); | |||
There was a problem hiding this comment.
At this point there should be a cryptoAPI, maybe we can just do getCrypto()! or maybe we could have a sort of getSafeCrypto() new API that would throw a End-to-end encryption disabled like the deprecatedimportRoomKeys was doing
There was a problem hiding this comment.
Good call - fixed in f1fbff9
andybalaam
force-pushed
the
andybalaam/use-nondeprecated-importroomkeys
branch
from
276acad
to
f1fbff9
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of element-hq/element-web#26681
This change is marked as an internal change (Task), so will not be included in the changelog.