Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Fix the image view #12341

Merged
merged 1 commit into from
Mar 14, 2024
Merged

Fix the image view #12341

merged 1 commit into from
Mar 14, 2024

Conversation

robintown
Copy link
Member

@robintown robintown commented Mar 14, 2024

Closes element-hq/element-web#27175

Notes: none

(No notes because the defect is not yet in a release)

@robintown robintown added the T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems label Mar 14, 2024
@robintown robintown requested a review from a team as a code owner March 14, 2024 15:11
@robintown robintown requested review from dbkr and richvdh March 14, 2024 15:11
@t3chguy t3chguy added backport staging Label to automatically backport PR to staging branch and removed backport staging Label to automatically backport PR to staging branch labels Mar 14, 2024
@robintown robintown enabled auto-merge March 14, 2024 15:12
@t3chguy
Copy link
Member

t3chguy commented Mar 14, 2024

(does not affect current release)

@robintown robintown removed request for dbkr and richvdh March 14, 2024 15:13
@robintown robintown added this pull request to the merge queue Mar 14, 2024
Merged via the queue into matrix-org:develop with commit 49be30b Mar 14, 2024
37 checks passed
@robintown robintown deleted the fix-image-view branch March 14, 2024 15:57
thoraj added a commit to verji/matrix-react-sdk that referenced this pull request Mar 15, 2024
* Update `@vector-im/compound-design-tokens` in package.json (matrix-org#12339)

* Change 'type' prop on badges to 'forceDot' (matrix-org#12327)

* Change 'type' prop on badges tio 'forceDot'

Which, hopefully, better represents what it actually does. Tidies
up some of the logic.

Split out from matrix-org#12254

* Missed a file

* More comments

* Oops, there is no count here.

* Back out the logic refactor of StatelessNotificationBadge

because it was also updating the logic for mark as unread badges and
rewriting the ternary to the previous logic would be quite complex.

* Fix doc comment

Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>

* Clarify doc on displaying the count

* Update doc for the forceDot param here too.

---------

Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>

* [Backport staging] Update `@vector-im/compound-design-tokens` in package.json (matrix-org#12340)

(cherry picked from commit e3ba643)

Co-authored-by: Florian Duros <florianduros@element.io>

* Fix the image view (matrix-org#12341)

* TAC: Fix hover state when expanded (matrix-org#12337)

* Fix TAC hover state

* Add playwright test

* Update playwright snapshot after last compound style changes

* v3.95.0-rc.0

* v3.95.0

* Reset matrix-js-sdk back to develop branch

* TAC: Order rooms by most recent after notification level (matrix-org#12329)

* Order room by thread timestamp

* Fix key errors in test

* Update jest snapshots

* Update snapshots

* Rename alpha/beta to numbers

* Add playwright test

* Replace forceCount prop with hideIfDot (matrix-org#12344)

This replaces the `forceCount` prop on room badge components with
`hideIfDot` which hopefully gives a better idea of what it does,
since forceCount did not really force a count. Also remove the
prop where it was just passing the default value anyway.

---------

Co-authored-by: Florian Duros <florianduros@element.io>
Co-authored-by: David Baker <dbkr@users.noreply.github.com>
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
Co-authored-by: ElementRobot <releases@riot.im>
Co-authored-by: Robin <robin@robin.town>
andybalaam pushed a commit that referenced this pull request Mar 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Image view is broken
2 participants