Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Call Guest Access, give user the option to change the acces level so they can generate a call link. #12401

Merged
merged 17 commits into from
Apr 10, 2024

Conversation

toger5
Copy link
Contributor

@toger5 toger5 commented Apr 4, 2024

If the room is not set to public or Knock invite rules one cannot share a call link.
This pr still shows the invite link button. Clicking will prompt the user to update their join rules to Knock (if enabled) or Public. If the user decides to do so the share dialog will be shown.

The share button is now only not visible if the user cannot change the join rules and the join rule is private.

screenshot:

Old screenshot Screenshot 2024-04-04 at 21 50 06
Screenshot 2024-04-05 at 10 53 57

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

src/i18n/strings/en_EN.json Outdated Show resolved Hide resolved
src/components/views/rooms/RoomHeader.tsx Outdated Show resolved Hide resolved
src/i18n/strings/en_EN.json Outdated Show resolved Hide resolved
src/i18n/strings/en_EN.json Outdated Show resolved Hide resolved
toger5 and others added 9 commits April 8, 2024 18:30
Signed-off-by: Timo K <toger5@hotmail.de>
Signed-off-by: Timo K <toger5@hotmail.de>
Signed-off-by: Timo K <toger5@hotmail.de>
Co-authored-by: Robin <robin@robin.town>
Signed-off-by: Timo K <toger5@hotmail.de>
Co-authored-by: Robin <robin@robin.town>
Co-authored-by: Robin <robin@robin.town>
Changing power level did not update the ui.

Signed-off-by: Timo K <toger5@hotmail.de>
Signed-off-by: Timo K <toger5@hotmail.de>
Signed-off-by: Timo K <toger5@hotmail.de>
Copy link
Member

@robintown robintown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing blocking

test/components/views/rooms/RoomHeader-test.tsx Outdated Show resolved Hide resolved
test/components/views/rooms/RoomHeader-test.tsx Outdated Show resolved Hide resolved
Signed-off-by: Timo K <toger5@hotmail.de>
@toger5 toger5 enabled auto-merge April 10, 2024 14:28
@toger5 toger5 added this pull request to the merge queue Apr 10, 2024
Merged via the queue into develop with commit d35fce1 Apr 10, 2024
22 checks passed
@toger5 toger5 deleted the toger5/ask-to-convert-v2 branch April 10, 2024 15:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants