Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Extract functions for service worker usage, and add initial MSC3916 playwright test (when supported) #12414

Merged
merged 31 commits into from
May 2, 2024
Merged

Extract functions for service worker usage, and add initial MSC3916 playwright test (when supported) #12414

merged 31 commits into from
May 2, 2024

Conversation

turt2live
Copy link
Member

@turt2live turt2live commented Apr 11, 2024 •
edited
Loading

For element-hq/element-web#27326

See #12414 (comment) for context

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

@turt2live turt2live added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Apr 11, 2024
@turt2live turt2live mentioned this pull request Apr 11, 2024
Merged
4 tasks
@turt2live
Add initial test
c5b18f3 
The test fails, seemingly because the service worker isn't being installed or because the network mock can't reach that far.
@turt2live turt2live changed the title Send user credentials to service worker for MSC3916 authentication Use service worker-safe access to crypto and IndexedDB storage Apr 18, 2024
@turt2live turt2live changed the title Use service worker-safe access to crypto and IndexedDB storage Use service worker-safe access to crypto and IndexedDB storage, and add Playwright test for MSC3916 auth Apr 18, 2024
@turt2live turt2live requested a review from richvdh April 23, 2024 19:33
richvdh
richvdh approved these changes Apr 24, 2024
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@turt2live turt2live enabled auto-merge April 30, 2024 19:02
@turt2live turt2live disabled auto-merge May 1, 2024 15:30
@github-actions github-actions bot deployed to Netlify May 2, 2024 21:33 Active
@turt2live turt2live enabled auto-merge May 2, 2024 21:58
@turt2live turt2live added this pull request to the merge queue May 2, 2024
Merged via the queue into develop with commit d25d529 May 2, 2024
30 checks passed
@turt2live turt2live deleted the travis/msc3916 branch May 2, 2024 22:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@richvdh richvdh richvdh approved these changes

@robintown robintown Awaiting requested review from robintown robintown is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@turt2live @richvdh