Remove old pre-join UTD logic #12464
Conversation
and add a playwright test for new pre-join UTD
uhoreg
added
the
T-Task
| // - second message sent by Bob (decryptable) | ||
| // - third message sent by Bob (undecryptable) | ||
| const tiles = await page.locator(".mx_EventTile").all(); | ||
| expect(tiles.length).toBeGreaterThanOrEqual(5); |
There was a problem hiding this comment.
OOI when will there be more than 5 tiles?
There was a problem hiding this comment.
It uses an EventTile for things like the thing that indicates that encryption is enabled. By the time we get to this point in the test, that tile will have disappeared. I'm not sure if other previous events will get a tile (I think they all get thrown in a group). But basically, by checking that the length is at least 5, if other bits of the react-sdk change so that other tiles are shown, this test won't immediately break.
There was a problem hiding this comment.
I already said this on a previous PR, but:
Could we just set msc4115_membership_on_events: true on the default template, rather than have all this copypasta?
There was a problem hiding this comment.
Right, I forgot about that previous comment when I was splitting this PR out.
I wasn't sure what was the policy about enabling experimental features on the default template, but since Synapse is going to enable it by default anyways, it shouldn't be a problem here.
and add a playwright test for new pre-join UTD
The playwright test depends on the docker image for Synapse to include element-hq/synapse#17104
Checklist
public/exportedsymbols have accurate TSDoc documentation.