Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Allow default for ctrl+shift+b, ctrl+shift+u in RTE #1274

Merged
merged 2 commits into from
Aug 7, 2017

Conversation

lukebarnard1
Copy link
Contributor

Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

// shortcuts for things).
if ([KeyCode.KEY_B, KeyCode.KEY_I, KeyCode.KEY_U].includes(e.keyCode) &&
e.shiftKey && e.ctrlKey
) {
// When null is returned, draft-js will NOT preventDefault, allowing dev tools
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe this comment is too specific now though

Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great - LGTM (again) :D

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Control-Shift-U is misinterpreted as underline markup
3 participants