Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Hide pinned messages when grouped in timeline when feature pinning is disabled #12888

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

florianduros
Copy link
Contributor

@florianduros florianduros commented Aug 14, 2024

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

When the message pinning is disabled, we are still displaying the pinned event in the timeline when grouped with other events. This PR is fixing this issue.

Since the bug is minor, not easily testable and the message pinning will leave beta soon. I didn't write a test.

Before After
Screenshot 2024-08-14 at 16 18 41 Screenshot 2024-08-14 at 16 19 53

@florianduros florianduros added the T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems label Aug 14, 2024
@florianduros florianduros changed the title florianduros/pinned-messages/timeline-event Hide pinned messages when grouped in timeline when feature pinning is disabled Aug 14, 2024
@florianduros florianduros marked this pull request as ready for review August 14, 2024 14:33
@florianduros florianduros requested a review from a team as a code owner August 14, 2024 14:33
@florianduros florianduros added this pull request to the merge queue Aug 14, 2024
Merged via the queue into develop with commit d9846dc Aug 14, 2024
48 of 49 checks passed
@florianduros florianduros deleted the florianduros/pinned-messages/timeline-event branch August 14, 2024 15:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants