Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Update playwright docker image #12930

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Update playwright docker image #12930

merged 1 commit into from
Aug 27, 2024

Conversation

florianduros
Copy link
Contributor

@florianduros florianduros commented Aug 26, 2024 •
edited
Loading

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

The playwright image needs to be updated.

After:

  • yarn install
  • playwright install

This error is raised
image

@florianduros florianduros changed the title Update playwright image Update playwright docker image Aug 26, 2024
@florianduros florianduros added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Aug 27, 2024
@florianduros florianduros marked this pull request as ready for review August 27, 2024 09:12
@florianduros florianduros requested a review from a team as a code owner August 27, 2024 09:12
@florianduros florianduros requested review from dbkr and t3chguy August 27, 2024 09:12
dbkr
dbkr approved these changes Aug 27, 2024
View reviewed changes
Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fwiw, https://github.com/matrix-org/matrix-react-sdk/pull/12909/files#diff-1563dec3d94363c2fb9f2e1224e2a23302bf5fdd8998c755d58330f617ad7de1 included this but is stuck because of the browser warning toast thing

@florianduros florianduros added this pull request to the merge queue Aug 27, 2024
Merged via the queue into develop with commit 30f84cd Aug 27, 2024
42 of 44 checks passed
@florianduros florianduros deleted the florianduros/update-playwright-image branch August 27, 2024 12:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dbkr dbkr dbkr approved these changes

@t3chguy t3chguy Awaiting requested review from t3chguy t3chguy is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@florianduros @dbkr