Implement download_file in widget driver #12931
Conversation
Signed-off-by: Michael Weimann <michael.weimann@nordeck.net>
github-actions
bot
added
the
Z-Community-PR
| return "https://example.com/_matrix/media/v3/download/test_file"; | ||
| } | ||
|
|
||
| return null; | ||
| }); | ||
|
|
||
| fetchMockJest.get("https://example.com/_matrix/media/v3/download/test_file", "test contents"); |
There was a problem hiding this comment.
wouldn't this be
| return "https://example.com/_matrix/media/v3/download/test_file"; | |
| } | |
| return null; | |
| }); | |
| fetchMockJest.get("https://example.com/_matrix/media/v3/download/test_file", "test contents"); | |
| return "https://example.com/_matrix/media/v3/download/example.com/test_file"; | |
| } | |
| return null; | |
| }); | |
| fetchMockJest.get("https://example.com/_matrix/media/v3/download/example.com/test_file", "test contents"); |
it might not be obvious why this calls the deprecated API, but maintainers will know better than me.
There was a problem hiding this comment.
wouldn't this be
Done
it might not be obvious why this calls the deprecated API, but maintainers will know better than me.
The implementation relies on Media . Not sure if the test should mock it away or not 🤷
Signed-off-by: Michael Weimann <michael.weimann@nordeck.net>
|
Hi! Can you first of all fix the lint and ts errors? |
florianduros
added
the
T-Enhancement
The „lint“ errors are actually type check errors caused by this PR relying on matrix-org/matrix-widget-api#99 |
|
here's described how to test everything together: matrix-org/matrix-widget-api#99 (comment) |
I think you should be able to update the package.json to use your widget api pr for the review and revert the change once the widget api is merged. To be more specific: |
Signed-off-by: Michael Weimann <michael.weimann@nordeck.net>
|
The change in the package.json made it worse |
langleyd
added
the
X-Release-Blocker
Hello @florianduros, could you please advise us what you need us to do to get this reviewed? Like weeman said, the lint errors are due to the wrong dependency version. How should we fix it? |
|
I'll review it in the afternoon. Why not waiting for the matrix-org/matrix-widget-api#99 PR to be released to ask for a review? It can't be merged without it. |
Code for both (and also a widget) is already done so we could test it end to end. We're asking for reviews of both PRs that target element repos. It seems to us to make sense to review both PRs at the same time. Some info maybe not obvious from the title and OP: this is a (partial) implementation of MSC4039. |
|
I've merged the widgets api PR and released it as 1.9.0 so you'll need tov change the dependency here (or allow edits so we can). |
Signed-off-by: Kim Brose <kim.brose@nordeck.net>
Implement the widget API
download_filein the widget driver.Needs matrix-org/matrix-widget-api#99
Checklist
public/exportedsymbols have accurate TSDoc documentation.