Fix spurious notifications #1339
Conversation
When loading new content whilst scrolling down the timeline . Use the Event event which only fire for events received in a sync, rather than Room.timeline which fires for events from pagination too.
|
This looks like it could inadvertently be affecting the logic for dealing with an event that's still being decrypted or has failed to be decrypted. |
|
we'll necessarily get Event before Event.decrypted so it shouldn't do? I tested it and it worked. Was there a particular failure mode you thought of? |
|
Nothing in particular, I'm just applying paranoia. Are events even being decrypted at the point |
|
I don't think the js-sdk makes any particular guarantees if the event is decrypted when you get the Event event or some time after, which is why we check if it's decrypted at the time of getting Event and if it's not, wait until it is. |
|
Right so now we won't be running this logic - including the bit for events potentially still being decrypted - when we paginate. This seems like it would cause different results for an event still being decrypted during pagination. |
|
The point is that we should never be notifying for events received through pagination. |
|
Yes but do we not want encrypted events to be added to |
|
No, Notifier's job is just showing notifications, so it doesn't care about events we won't notify for. |
|
Oh 🙂 that's fine then |
When loading new content whilst scrolling down the timeline .
Use the Event event which only fire for events received in a sync,
rather than Room.timeline which fires for events from pagination
too.
Fixes element-hq/element-web#2608
Fixes element-hq/element-web#1603