Enhancements to room power level settings #1440
Conversation
Signed-off-by: Travis Ralston <travpc@gmail.com>
This does mean that the strings will need to be re-translated, but now they may be more accurate because the comma is not assumed in the code. Signed-off-by: Travis Ralston <travpc@gmail.com>
Signed-off-by: Travis Ralston <travpc@gmail.com>
Signed-off-by: Travis Ralston <travpc@gmail.com>
Signed-off-by: Travis Ralston <travpc@gmail.com>
Fixes element-hq/element-web#4866 Signed-off-by: Travis Ralston <travpc@gmail.com>
turt2live
force-pushed
the
travis/pl_enhancements
branch
from
ae34e14
to
20798dd
Compare
|
Would it be possible to do some grouping and maybe change the order a bit? E.g. kicking and removing messages is clearly about moderation, while setting the topic and room name is about room configuration. You also have "To change the room's ..." or similar in each case except for the topic. Also, how does the "To configure the room" setting affect the other room configuration things (like setting avatar, topic, etc.) ? |
|
Sections would be a great addition, although I don't know how they'd look in the settings page. The configure room permission is unchanged by this. It is the default for who can set events that aren't defined in the list. |
That should probably be explained somewhere. Or perhaps change the text to "To configure other room settings ..." ? |
| @@ -35,6 +35,31 @@ function parseIntWithDefault(val, def) { | |||
| return isNaN(res) ? def : res; | |||
| } | |||
|
|
|||
| const plEventsToLabels = { | |||
| // These will be translated for us later. | |||
| // TODO: _td() these when https://github.com/matrix-org/matrix-react-sdk/pull/1421 lands | |||
There was a problem hiding this comment.
This has landed, so feel free to _td these
| @@ -364,6 +389,11 @@ module.exports = React.createClass({ | |||
| var powerLevels = this.props.room.currentState.getStateEvents('m.room.power_levels', ''); | |||
| powerLevels = powerLevels ? powerLevels.getContent() : {}; | |||
|
|
|||
| for (let key of Object.keys(this.refs).filter(k => k.startsWith("event_levels_"))) { | |||
There was a problem hiding this comment.
Given that this would require a lot more work if we used state, this is probably fine. @dbkr do you have thoughts on this?
There was a problem hiding this comment.
tbh I only used refs because the rest of the powerlevels use refs.
|
FTR there is a plan to totally reorganise room settings so that there are sections and a uniform concept of "saving". Separately, I mocked up some designs for a redesigned power level display: |
Signed-off-by: Travis Ralston <travpc@gmail.com>
|
@lukebarnard1 I've added The RoomSettings (and UserSettings) are a bit of a mess in my opinion. I'm okay with the current power level structure in the settings personally, it's fairly clear who can do what. Although I do like your proposed idea of showing who can do what closer to the actual permissions, instead of having to figure it out yourself (design C, mostly). |
Changes: