This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
fix missing date sep caused by hidden event at start of day #1537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if first event in day was hidden, the date sep would go missing as the next event would compare its date to the hidden one instead of the one before it due to naive N-1 check rather than a previous valid event comparison, now fixed by comparing date against the first event in MELS instead. Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
lukebarnard1
approved these changes
Oct 25, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if first event in day was hidden, the date sep would go missing as the next event would compare its date to the hidden one instead of the one before it
due to naive N-1 check rather than a previous valid event comparison, now fixed by comparing date against the first event in MELS instead (MELS breaks apart into multiple MELSes on date changes so this is valid)
Signed-off-by: Michael Telatynski 7t3chguy@gmail.com