This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Send Access Token in Headers to help prevent it being spit out in errors #1552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
|
i have a bad feeling that this will wreak havoc on some of the analytics we have which trawl through haproxy logs to spot patterns (and rely on sniffing access_tokens to track sessions)... |
|
i agree it's generally desirable though. |
|
@ara4n: I'd suggest the solution to the analytics is to add the Authorization header to the list of request headers we capture, so that it is included in the logs. (see We'll also need to update the cross-synchrotron load-balancing to look for Authorization headers. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michael Telatynski 7t3chguy@gmail.com