Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Fix TextualBody.js to remove NodeList.forEach() #1768

Merged
merged 1 commit into from
Mar 20, 2018

Conversation

adi1
Copy link
Contributor

@adi1 adi1 commented Feb 22, 2018

Not all browsers support forEach() on NodeList objects. This causes crashes on some browsers, such as IE and FF<50.

Signed-off-by: Adrian Hossu adrian@freetrainers.com

Not all browsers support forEach() on NodeList objects. This causes crashes on some browsers, such as IE and FF<50.
Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally I'd say this should just be a normal for... of loop now that this is a sensible thing. Not super important though.

@dbkr dbkr merged commit 2f564b8 into matrix-org:develop Mar 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants