This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Don't notify for bad encrypted messages #1818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Continue to wait for decryption if the decryption process failed. Because we weren't doing this, the first message in a megolm session was generally failing to decrypt the first time because the keys often arrive after the message. Fixes element-hq/element-web#6284 This is is small & safe enough that we may want to consider putting it in 0.14 if we're cutting another RC.
lukebarnard1
approved these changes
Mar 29, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continue to wait for decryption if the decryption process failed.
Because we weren't doing this, the first message in a megolm session
was generally failing to decrypt the first time because the keys often
arrive after the message.
Fixes element-hq/element-web#6284
This is is small & safe enough that we may want to consider
putting it in 0.14 if we're cutting another RC.
@lukebarnard1 I've assigned this to you but feel free to punt it to Rich if you don't feel like you have enough context