Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Add 500ms delay to show membershipBusy for longer #1832

Merged
merged 2 commits into from
Apr 10, 2018
Merged

Add 500ms delay to show membershipBusy for longer #1832

merged 2 commits into from
Apr 10, 2018

Conversation

lukebarnard1
Copy link
Contributor

to avoid a UI that flashes quickly

@lukebarnard1
Add 500ms delay to show membershipBusy for longer
31e9979 
to avoid a UI that flashes quickly
dbkr
dbkr reviewed Apr 10, 2018
View reviewed changes
Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, although could use a comment on why this waits before sending the request rather than waiting at least 500ms before dismissing stuff.

@dbkr dbkr assigned lukebarnard1 and unassigned dbkr Apr 10, 2018
@lukebarnard1 lukebarnard1 merged commit 1b01c30 into develop Apr 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dbkr dbkr dbkr left review comments

Assignees

@lukebarnard1 lukebarnard1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukebarnard1 @dbkr