This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Add UI for displaying room avatars full size #1843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the onClick action on the RoomAvatar inside RoomHeader so that it brings up a lightbox with the full-size avatar.
|
even though it doesn't handle 1:1 rooms with implicit avatars, i think this is a good enough start - thanks! lgtm! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the
onClickaction on theRoomAvatarinsideRoomHeaderso that it bringsup a lightbox with the full-size avatar.
This does not work for one-to-one rooms (it displays an empty lightbox) when they do not have an avatar set and are using the user avatars, and I do not think I can implement this nicely without refactoring URL-fetching code.
Addresses element-hq/element-web#2502.
Signed-off-by: Aidan Gauland aidalgol+ghpr@fastmail.net