This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Users should always be able to edit their user/non-room widgets #1879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks plausible modulo duff tests |
t3chguy
reviewed
May 8, 2018
| @@ -274,6 +274,11 @@ export default class AppTile extends React.Component { | |||
| } | |||
|
|
|||
| _canUserModify() { | |||
| // User widgets should always be modifiable by their creator | |||
| if (this.props.userWidget && MatrixClientPeg.get().credentials.userId === this.props.creatorUserId) { | |||
There was a problem hiding this comment.
I've recently been pointed to get the MatrixClient instance over React Contexts, probably worth pointing out here also
There was a problem hiding this comment.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"User widgets" such as sticker pickers should always be editable by their owner (regardless of the room that they are currently viewing).