Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Select audio output for WebRTC #1932

Merged
merged 3 commits into from
Jun 14, 2018
Merged

Select audio output for WebRTC #1932

merged 3 commits into from
Jun 14, 2018

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented May 26, 2018

@t3chguy
Allow selecting audio output for WebRTC Audio/Video calls
6636fa3 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
run gen-i18n and prune-i18n
689b00c 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
dbkr
dbkr reviewed Jun 8, 2018
View reviewed changes
Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless I'm missing something, it looks like this only calls the js-sdk function to set the audio output when the setting is changed, which means if you refresh it will reset to the default, even though the preference is saved as a setting?

@t3chguy
Copy link
Member Author

t3chguy commented Jun 8, 2018

@dbkr see callmediahandler::loadDevices

@dbkr
Copy link
Member

dbkr commented Jun 14, 2018

ah, that's what I was missing, thanks.

@t3chguy
Copy link
Member Author

t3chguy commented Jun 14, 2018

Thanks! Merge conflict resolved, waiting for CI

@t3chguy t3chguy merged commit 3165a99 into develop Jun 14, 2018
@t3chguy t3chguy deleted the t3chguy/audio_output branch May 25, 2020 18:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dbkr dbkr dbkr approved these changes

Assignees

@t3chguy t3chguy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@t3chguy @dbkr