Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

on HTML Imgs copy alt to title if there is no title to provide tooltip #2004

Closed
wants to merge 3 commits into from

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Jun 22, 2018

Especially helpful when someone's using a client capable of custom emojis which may or may not be unclear:
image
which currently have no hover tooltip because they only provide an alt
so now they magically will show a tooltip

Fixes element-hq/element-web#6917

t3chguy added 3 commits June 22, 2018 08:52
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@dbkr
Copy link
Member

dbkr commented Jun 25, 2018

Hmm - I'm not really convinced it's Riot's place to go fixing up other clients' HTML.

Also, I'd suggest putting linting fixes in a separate PR, especially when the actual change ends up being 5% of the content of the PR - it makes it quite hard to review when you have to hunt for the actual change in amongst linting fixes.

@t3chguy
Copy link
Member Author

t3chguy commented Jun 25, 2018

Hmm - I'm not really convinced it's Riot's place to go fixing up other clients' HTML.

sure but making Riot as useful as it can be given any input is my way of thinking about it

@lukebarnard1
Copy link
Contributor

lukebarnard1 commented Jun 25, 2018

I'm not convinced this would be a plus for accessibility: https://silktide.com/i-thought-title-text-improved-accessibility-i-was-wrong/

I also think it's up to the sending client to send messages that are accessible. Sending an alt that is :man_shrugging: or whatever is probably fine for screen readers as they read the img alt by default (although with orca, it'll read "man underscore shrugging").

As for adding a tooltip to an inline img, I think that's down to the sending client again.

cc. @lampholder

@bwindels bwindels assigned bwindels and unassigned bwindels Jul 9, 2018
@jryans
Copy link
Collaborator

jryans commented Jul 31, 2019

Thanks for making this contribution a while back. Since the code base has changed since this was opened, it no longer applies cleanly, and I don't think there's a need to keep it open in this state, as we can always find the code here again if needed. If you are still interested in pursuing this feature, please discuss with us in #riot-dev:matrix.org to find a good approach forward.

@jryans jryans closed this Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

html images: copy alt to title if no title
5 participants