Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

prevent user,room,group autocomplete firing mid-word #2012

Merged
merged 1 commit into from
Jun 25, 2018

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Jun 25, 2018

Fixes element-hq/element-web#6929

any removed capture groups were actually unused this time :D

Signed-off-by: Michael Telatynski 7t3chguy@gmail.com

to stop the autocompleter firing mid-word
and remove any unused capture groups

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@lukebarnard1 lukebarnard1 self-assigned this Jun 25, 2018
Copy link
Contributor

@lukebarnard1 lukebarnard1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

(It's a shame how subtly the regexp groups are being used here. AutocompleteProvider should probably not pass back the regexp match as command. But this is a separate issue.)

@lukebarnard1 lukebarnard1 merged commit fc81636 into develop Jun 25, 2018
@t3chguy t3chguy deleted the t3chguy/autocomplete_mid_word branch May 25, 2020 18:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants