This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Allow jitsi in e2e rooms #2075
Merged
Allow jitsi in e2e rooms #2075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have a separate warning about how widgets are not very e2e, so this should be sufficient warning.
bwindels
reviewed
Jul 20, 2018
| }); | ||
| return; | ||
| } | ||
|
|
||
| if (SettingsStore.isFeatureEnabled('feature_jitsi')) { |
There was a problem hiding this comment.
if jitsi is not enabled, the reason we don't start the call is not really that it's not supported in e2e encrypted rooms, is it? Should we change the error message? Or is this about freeswitch calls not working in e2e encrypted rooms?
There was a problem hiding this comment.
yep, if jitsi's not enabled then we use freeswitch which we haven't supported in e2e rooms since it would just send your media to freeswitch which isn't very e2e. (Jitsi is no different but there's a separate general warning for widgets)
bwindels
approved these changes
Jul 20, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a separate warning about how widgets are not very e2e, so
this should be sufficient warning.