This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Warning bar for MAU limit hit #2114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Somewhat untested, sorry
bwindels
reviewed
Aug 13, 2018
| }, | ||
|
|
||
| componentWillUnmount: function() { | ||
| document.removeEventListener('keydown', this._onKeyDown); | ||
| this._matrixClient.removeListener("accountData", this.onAccountData); | ||
| this._matrixClient.removeListener("sync", this.onSync); |
| if (this.props.kind === 'hard') { | ||
| toolbarClasses['mx_MatrixToolbar_error'] = true; | ||
| content = _t( | ||
| "This homeserver has hit its Monthly Active User limit. Please <a>contact your service administrator</a> to continue using the service.", |
There was a problem hiding this comment.
This would be shown when (initial) sync has failed I think, but wouldn't it be very confusing to just show a banner, but still the complete UI, but you can't interact with the server in any meaningful way? (or is that not what M_MAU_LIMIT_EXCEEDED causes?). Maybe I'm missing something, but cancelling login and showing an error message on the login page would be clearer if this is the case.
There was a problem hiding this comment.
I think the idea is that you can still see the messages you've already synced, although it's tied quite heavily into the fact that causing a logout causes the client to delete its e2e keys: I think this may be the intention in the long term once we work out how to do it.
The initialisation here is done on a timer to allow the DOM elements to be in place before it's run, so it's possible for an update to happen ebfore the initialisation. Stop & bail out if there is no this.stickies.
bwindels
approved these changes
Aug 13, 2018
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somewhat untested, sorry