This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
fix last_active_ago timestamps, tab completion ordering, and implement currently_active semantics #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 16, 2016
Closed
…ocomplete based on the most recently active users in a room, even if we can't spell the first char of their name. it does break tab-complete for accessibility, but that was broken anyway.
| // _|__ _|_ followed by the end of line | ||
| // / \/ \ | ||
| const MATCH_REGEX = /(^|\s)(\S+)$/; | ||
| const MATCH_REGEX = /(^|\s)(\S*)$/; |
There was a problem hiding this comment.
why is this changing? it scares me
There was a problem hiding this comment.
as the commit says, it lets you hit tab on an empty textarea to start tab-completing the most recently active nick
| active = ( | ||
| (Date.now() - (user.lastPresenceTs - user.lastActiveAgo)) || -1 | ||
| ); | ||
| active = member.user.lastActiveAgo ? |
There was a problem hiding this comment.
oooooooops, good catch; thanks
|
@dbkr PTAL |
|
lgtm |
ara4n
added a commit
that referenced
this pull request
Mar 17, 2016
fix last_active_ago timestamps, tab completion ordering, and implement currently_active semantics
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.