This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Ignore failing group users response #2295
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Synapse is currently known (matrix-org/synapse#2633) to return 500 errors for requests to `/groups/$groupId/users` when a user has multiple invites to the group. If you are affected by this issue, Riot will display a community invite when you select it for a few seconds until it receives this 500 error, but then it will replace the invite view with a "Failed to load <group>" message. By ignoring this error response in Riot for now, it is possible to view and accept the invite. Fixes element-hq/element-web#7727. Signed-off-by: J. Ryan Stinnett <jryans@gmail.com>
|
I'd honestly prefer if we at least had a message saying "failed to load community members" on the right side. @lampholder wdyt? |
|
I agree - if we express the error condition somehow at least it looks like something is wrong (rather than this is just a community with somehow no members). |
|
Thanks for the feedback! I agree it does seem better to keep the error visible for both the user to be informed and to keep pressure on Synapse to fix the root cause. Since that's a very different approach, I'll close this and open a new PR for that. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Synapse is currently known (matrix-org/synapse#2633) to return 500 errors for
requests to
/groups/$groupId/userswhen a user has multiple invites to thegroup.
If you are affected by this issue, Riot will display a community invite when you
select it for a few seconds until it receives this 500 error, but then it will
replace the invite view with a "Failed to load " message.
By ignoring this error response in Riot for now, it is possible to view and
accept the invite.
Fixes element-hq/element-web#7727.
Signed-off-by: J. Ryan Stinnett jryans@gmail.com