This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Expose hidden notification rules in UI #2346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jryans
commented
Dec 11, 2018
src/i18n/strings/en_EN.json
Outdated
| @@ -912,7 +915,6 @@ | |||
| "You've previously used a newer version of Riot on %(host)s. To use this version again with end to end encryption, you will need to sign out and back in again. ": "You've previously used a newer version of Riot on %(host)s. To use this version again with end to end encryption, you will need to sign out and back in again. ", | |||
| "Incompatible Database": "Incompatible Database", | |||
| "Continue With Encryption Disabled": "Continue With Encryption Disabled", | |||
| "Failed to indicate account erasure": "Failed to indicate account erasure", | |||
There was a problem hiding this comment.
This string is no longer used after 328d57f.
There was a problem hiding this comment.
also removed in #2338 (comment) :p
(we should probably just commit it directly)
jryans
force-pushed
the
expose-push-rules
branch
from
469b1af to
d3b3ee0
Compare
turt2live
approved these changes
Dec 11, 2018
Adds UI control for 3 hidden notification rules: * Messages containing @room * Encrypted one-to-one messages * Encrypted group messages This should help to clarify some mysterious notification behavior, as it wasn't obvious that these rules existed. Fixes element-hq/element-web#7833. Signed-off-by: J. Ryan Stinnett <jryans@gmail.com>
jryans
force-pushed
the
expose-push-rules
branch
from
d3b3ee0 to
04c3018
Compare
|
I had pushed after review to fix a typo, but then didn't actually add the change... 😓 I fixed it for real in 2ca7477. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds UI control for 3 hidden notification rules:
This should help to clarify some mysterious notification behavior, as it wasn't
obvious that these rules existed.
Fixes element-hq/element-web#7833.
Signed-off-by: J. Ryan Stinnett jryans@gmail.com